Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes middle and right click for home button #9672

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Fixes middle and right click for home button #9672

merged 1 commit into from
Jun 23, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 22, 2017 •
edited by bsclifton
Loading

Test Plan

  • try to right click on the home button
  • try middle clicking on the home button with title mode ON and OFF

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #9562
Resolves #9665

Auditors: @bsclifton

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

retry of #9564

@NejcZdovc
Fixes middle and right click for home button
4efc85b 
Resolves brave#9562
Resolves brave#9665

Auditors: @bsclifton

Test Plan:
- try to right click on the home button
- try middle clicking on the home button with title mode ON and OFF
@NejcZdovc NejcZdovc added this to the 0.17.x (Beta Channel) milestone Jun 22, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 22, 2017
@NejcZdovc NejcZdovc requested a review from bsclifton June 22, 2017 21:27
@NejcZdovc NejcZdovc mentioned this pull request Jun 23, 2017
Closed
@bsclifton bsclifton mentioned this pull request Jun 23, 2017
Closed
bsclifton
bsclifton approved these changes Jun 23, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass; it works great and is much cleaner as its own control. Great job! 😄 👍

@bsclifton bsclifton merged commit e79ab87 into brave:master Jun 23, 2017
bsclifton added a commit that referenced this pull request Jun 23, 2017
@bsclifton
Merge pull request #9672 from NejcZdovc/hotfix/#9562-homebutton2
7c77ab1 
Fixes middle and right click for home button
bsclifton added a commit that referenced this pull request Jun 23, 2017
@bsclifton
Merge pull request #9672 from NejcZdovc/hotfix/#9562-homebutton2
9196362 
Fixes middle and right click for home button
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/navbar
Projects
None yet
Milestone
0.17.13 (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @bsclifton