-
Notifications
You must be signed in to change notification settings - Fork 974
Fixes middle click not working for home button #9564
Conversation
Resolves brave#9562 Auditors: @bsclifton Test Plan: - middle click on Home button - new tab is opened
fbac125
to
586a8ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code works good; I tested with single and multiple (separated with |) and it worked as expected. You can of course also use cmd + click
However, the test is failing for me locally (reproducible each time):
npm run test -- --grep="opens home page in a new tab when middle mouse button is clicked"
It looks OK on travis:
https://travis-ci.org/brave/browser-laptop/jobs/244416657#L3093
@bsclifton thing is that this whole block is connected so you need to run the whole block ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-ran tests (thanks for the heads up that they're part of a block). Changes LGTM 😄 👍
Ideal situation would be each test has what it needs (ex: get # of tabs, do a +1, then expect that number... or restructure to before each as mentioned above). For now, this totally works though 😄 Merging! |
Fixes middle click not working for home button
Fixes middle click not working for home button
Test Plan:
Description
Submitter Checklist:
git rebase -i
to squash commits (if needed).Resolves #9562
Auditors: @bsclifton
Reviewer Checklist: