Bump Python version to 3.10 and add `gazebo` dependencies #8

flferretti · 2024-05-18T09:57:13Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

conda-forge-webservices · 2024-05-18T09:57:20Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

flferretti · 2024-05-18T09:57:41Z

@conda-forge-admin, please rerender

diegoferigo · 2024-05-18T11:41:40Z

Can we also add the gazebo dependencies in this PR?

diegoferigo

This should work! Thanks @flferretti.

@traversaro A curiosity, considering the way the Gazebo Sim suite is packaged distributed for side-to-side installation, is there any way to specify different combinations of packages? For example, in this case, both gz-tools2 libsdformat13 and gz-tools2 libsdformat14 would work.

diegoferigo · 2024-05-20T07:27:37Z

@flferretti by chance have you tried to also run pytest as part of the recipe? Having the gazebo dependencies there, the rod test suite should be working fine.

recipe/meta.yaml

…nda-forge-pinning 2024.05.18.00.22.24

traversaro · 2024-05-20T07:33:23Z

@traversaro A curiosity, considering the way the Gazebo Sim suite is packaged distributed for side-to-side installation, is there any way to specify different combinations of packages? For example, in this case, both gz-tools2 libsdformat13 and gz-tools2 libsdformat14 would work.

This is one downside of having a package for each major version. You can't specify that both libsdformat13 or libsdformat14 are ok, without creating two variant of the package (that is odd for a pure python package). Probably it could make sense to have a libsdformat meta package that depends on libsdformat13 or libsdformat14 depending on its version to properly support this.

flferretti · 2024-05-20T07:38:03Z

@traversaro A curiosity, considering the way the Gazebo Sim suite is packaged distributed for side-to-side installation, is there any way to specify different combinations of packages? For example, in this case, both gz-tools2 libsdformat13 and gz-tools2 libsdformat14 would work.

This is one downside of having a package for each major version. You can't specify that both libsdformat13 or libsdformat14 are ok, without creating two variant of the package (that is odd for a pure python package). Probably it could make sense to have a libsdformat meta package that depends on libsdformat13 or libsdformat14 depending on its version to properly support this.

Can we specify something like this libsdformat*>=13 ? It works if I try to run conda install libsdformat*>=13

traversaro · 2024-05-20T07:40:40Z

Can we specify something like this libsdformat*>=13 ? It works if I try to run conda install libsdformat*>=13

Oh cool, I had no idea. To be honest I am a bit afraid of this, metadata will be processed by several codebases (conda, mamba and pixi basically all use different codebases for this) so I am not 100% sure this will produce the same result.

flferretti · 2024-05-20T07:44:00Z

Okay thanks! So I guess it's safer to just keep libsdformat13 for the time being

traversaro · 2024-05-20T07:44:31Z

@traversaro A curiosity, considering the way the Gazebo Sim suite is packaged distributed for side-to-side installation, is there any way to specify different combinations of packages? For example, in this case, both gz-tools2 libsdformat13 and gz-tools2 libsdformat14 would work.

This is one downside of having a package for each major version. You can't specify that both libsdformat13 or libsdformat14 are ok, without creating two variant of the package (that is odd for a pure python package). Probably it could make sense to have a libsdformat meta package that depends on libsdformat13 or libsdformat14 depending on its version to properly support this.

See conda-forge/libsdformat-feedstock#118 .

flferretti · 2024-05-20T07:48:00Z

@flferretti by chance have you tried to also run pytest as part of the recipe? Having the gazebo dependencies there, the rod test suite should be working fine.

Done in 6581ece

traversaro · 2024-05-20T07:56:24Z

If you do not install any test as part of the package, probably you need either to pass the tests as test files (better), or run the tests as part of the build step.

diegoferigo · 2024-05-20T07:59:37Z

@traversaro A curiosity, considering the way the Gazebo Sim suite is packaged distributed for side-to-side installation, is there any way to specify different combinations of packages? For example, in this case, both gz-tools2 libsdformat13 and gz-tools2 libsdformat14 would work.

This is one downside of having a package for each major version. You can't specify that both libsdformat13 or libsdformat14 are ok, without creating two variant of the package (that is odd for a pure python package). Probably it could make sense to have a libsdformat meta package that depends on libsdformat13 or libsdformat14 depending on its version to properly support this.

Can we specify something like this libsdformat*>=13 ? It works if I try to run conda install libsdformat*>=13

If it works, it's a clever workaround.

In any case, supporting multiple versions is not blocking. The sdformat package doesn't have a lot of dependencies, if old versions keep being rebuilt in case of migrations and can be installed side-by-side with new versions (therefore not interfering with the solver in case new versions are required in an environment), I guess we're pretty robust also with only the minimum requirement that is gz-tools2 libsdformat13.

flferretti · 2024-05-20T10:05:52Z

Since the workaround does not work in the meta.yaml, I believe we can stick to libsdformat13.

For what regards the tests, I'm getting an error on libGL when importing idyntree:

ImportError while importing test module '$SRC_DIR/tests/test_urdf_exporter.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/_pytest/python.py:487: in importtestmodule
    mod = import_path(
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/_pytest/pathlib.py:591: in import_path
    importlib.import_module(module_name)
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1387: in _gcd_import
    ???
<frozen importlib._bootstrap>:1360: in _find_and_load
    ???
<frozen importlib._bootstrap>:1331: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:935: in _load_unlocked
    ???
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/_pytest/assertion/rewrite.py:178: in exec_module
    exec(co, module.__dict__)
tests/test_urdf_exporter.py:1: in <module>
    import idyntree.bindings as idt
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/idyntree/__init__.py:1: in <module>
    from . import swig
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/idyntree/swig.py:10: in <module>
    from . import _iDynTree
E   ImportError: libGL.so.1: cannot open shared object file: No such file or directory

C.C. @traversaro

flferretti · 2024-05-20T10:09:09Z

Since the workaround does not work in the meta.yaml, I believe we can stick to libsdformat13.

For what regards the tests, I'm getting an error on libGL when importing idyntree:

ImportError while importing test module '$SRC_DIR/tests/test_urdf_exporter.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/_pytest/python.py:487: in importtestmodule
    mod = import_path(
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/_pytest/pathlib.py:591: in import_path
    importlib.import_module(module_name)
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1387: in _gcd_import
    ???
<frozen importlib._bootstrap>:1360: in _find_and_load
    ???
<frozen importlib._bootstrap>:1331: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:935: in _load_unlocked
    ???
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/_pytest/assertion/rewrite.py:178: in exec_module
    exec(co, module.__dict__)
tests/test_urdf_exporter.py:1: in <module>
    import idyntree.bindings as idt
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/idyntree/__init__.py:1: in <module>
    from . import swig
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/idyntree/swig.py:10: in <module>
    from . import _iDynTree
E   ImportError: libGL.so.1: cannot open shared object file: No such file or directory

C.C. @traversaro

Probably solved by https://conda-forge.org/docs/maintainer/maintainer_faq/#how-do-i-fix-the-libglso1-import-error

traversaro · 2024-05-20T10:17:21Z

Since the workaround does not work in the meta.yaml, I believe we can stick to libsdformat13.
For what regards the tests, I'm getting an error on libGL when importing idyntree:

ImportError while importing test module '$SRC_DIR/tests/test_urdf_exporter.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/_pytest/python.py:487: in importtestmodule
    mod = import_path(
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/_pytest/pathlib.py:591: in import_path
    importlib.import_module(module_name)
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1387: in _gcd_import
    ???
<frozen importlib._bootstrap>:1360: in _find_and_load
    ???
<frozen importlib._bootstrap>:1331: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:935: in _load_unlocked
    ???
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/_pytest/assertion/rewrite.py:178: in exec_module
    exec(co, module.__dict__)
tests/test_urdf_exporter.py:1: in <module>
    import idyntree.bindings as idt
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/idyntree/__init__.py:1: in <module>
    from . import swig
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/site-packages/idyntree/swig.py:10: in <module>
    from . import _iDynTree
E   ImportError: libGL.so.1: cannot open shared object file: No such file or directory

C.C. @traversaro

Probably solved by https://conda-forge.org/docs/maintainer/maintainer_faq/#how-do-i-fix-the-libglso1-import-error

Yes, you also need to re-render probably.

flferretti · 2024-05-20T10:29:14Z

@conda-forge-admin, please rerender

flferretti · 2024-05-20T10:44:29Z

It didn't work, I'm checking again to see if I'm missing something

diegoferigo · 2024-05-20T10:48:24Z

Probably some other packages are missing, check:

https://github.com/conda-forge/idyntree-feedstock/blob/main/recipe/yum_requirements.txt

…nda-forge-pinning 2024.05.20.05.45.14

flferretti · 2024-05-20T11:12:02Z

@conda-forge-admin, please rerender

github-actions · 2024-05-20T11:13:26Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/rod-feedstock/actions/runs/9157803404.

flferretti · 2024-05-20T11:20:33Z

Probably some other packages are missing, check:

https://github.com/conda-forge/idyntree-feedstock/blob/main/recipe/yum_requirements.txt

Thanks Diego! Yet for some reason it looks like it still doesn't work

diegoferigo · 2024-05-20T11:48:19Z

@conda-forge-admin, please rerender

github-actions · 2024-05-20T11:49:59Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/rod-feedstock/actions/runs/9158205457.

diegoferigo · 2024-05-20T11:56:23Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2024.05.20.05.45.14

flferretti · 2024-05-20T11:58:39Z

I just noticed the extension, sorry

diegoferigo

No problem, LGTM as soon as CI turns green

diegoferigo · 2024-05-20T12:16:30Z

I have no idea why gitpython required by robot_descriptions does not have git as run requirements:

https://github.com/conda-forge/gitpython-feedstock/blob/7eafcb6a08ecfc216fbd0bd4319a88b66d2901db/recipe/meta.yaml#L21-L24

flferretti · 2024-05-20T12:19:25Z

See beeware/beeware#32 (comment), conda-forge/staged-recipes#19349 (comment)

flferretti requested review from diegoferigo and traversaro as code owners May 18, 2024 09:57

flferretti self-assigned this May 18, 2024

traversaro approved these changes May 18, 2024

View reviewed changes

flferretti changed the title ~~Bump Python version to 3.10~~ Bump Python version to 3.10 and add gazebo dependencies May 18, 2024

diegoferigo approved these changes May 20, 2024

View reviewed changes

diegoferigo requested changes May 20, 2024

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

flferretti and others added 3 commits May 20, 2024 09:31

Bump Python version to 3.10

7961a3b

MNT: Re-rendered with conda-build 24.5.0, conda-smithy 3.35.1, and co…

bf71e7f

…nda-forge-pinning 2024.05.18.00.22.24

Add gazebo dependencies

67c144a

flferretti force-pushed the flferretti-patch-1 branch from 13ed5aa to 20b1198 Compare May 20, 2024 07:41

flferretti force-pushed the flferretti-patch-1 branch from 20b1198 to 9223264 Compare May 20, 2024 07:47

Test recipe using pytest

6581ece

flferretti force-pushed the flferretti-patch-1 branch from 9223264 to 6581ece Compare May 20, 2024 09:31

flferretti and others added 2 commits May 20, 2024 13:11

Add idyntree deps in yum_requirements

d7a6024

MNT: Re-rendered with conda-build 24.5.0, conda-smithy 3.36.0, and co…

edc0912

…nda-forge-pinning 2024.05.20.05.45.14

flferretti force-pushed the flferretti-patch-1 branch from 037853f to edc0912 Compare May 20, 2024 11:12

Update yum_requirements.yml

584cc64

Fix extension of yum_requirements file

073066e

MNT: Re-rendered with conda-build 24.5.0, conda-smithy 3.36.0, and co…

3b49a35

…nda-forge-pinning 2024.05.20.05.45.14

diegoferigo approved these changes May 20, 2024

View reviewed changes

Add git dependency for tests

8076b85

diegoferigo mentioned this pull request May 20, 2024

Add git dependency conda-forge/robot_descriptions-feedstock#10

Closed

1 task

flferretti merged commit 6968516 into conda-forge:main May 20, 2024
3 checks passed

flferretti deleted the flferretti-patch-1 branch May 20, 2024 12:29

diegoferigo mentioned this pull request Jun 5, 2024

Add git run requirement conda-forge/gitpython-feedstock#80

Closed

1 task

diegoferigo mentioned this pull request Aug 20, 2024

Drop CDT and use conda-forge packages to provide OpenGL on Linux conda-forge/idyntree-feedstock#99

Merged

5 tasks

flferretti mentioned this pull request Aug 21, 2024

Remove dependencies installation via yum #9

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Python version to 3.10 and add `gazebo` dependencies #8

Bump Python version to 3.10 and add `gazebo` dependencies #8

flferretti commented May 18, 2024 •

edited

Loading

conda-forge-webservices bot commented May 18, 2024

flferretti commented May 18, 2024

diegoferigo commented May 18, 2024

diegoferigo left a comment

diegoferigo commented May 20, 2024

traversaro commented May 20, 2024

flferretti commented May 20, 2024 •

edited

Loading

traversaro commented May 20, 2024

flferretti commented May 20, 2024

traversaro commented May 20, 2024

flferretti commented May 20, 2024 •

edited

Loading

traversaro commented May 20, 2024

diegoferigo commented May 20, 2024

flferretti commented May 20, 2024

flferretti commented May 20, 2024 •

edited

Loading

traversaro commented May 20, 2024

flferretti commented May 20, 2024

flferretti commented May 20, 2024

diegoferigo commented May 20, 2024

flferretti commented May 20, 2024

github-actions bot commented May 20, 2024

flferretti commented May 20, 2024

diegoferigo commented May 20, 2024

github-actions bot commented May 20, 2024

diegoferigo commented May 20, 2024

flferretti commented May 20, 2024

diegoferigo left a comment

diegoferigo commented May 20, 2024 •

edited

Loading

flferretti commented May 20, 2024 •

edited

Loading

Bump Python version to 3.10 and add gazebo dependencies #8

Bump Python version to 3.10 and add gazebo dependencies #8

Conversation

flferretti commented May 18, 2024 • edited Loading

conda-forge-webservices bot commented May 18, 2024

flferretti commented May 18, 2024

diegoferigo commented May 18, 2024

diegoferigo left a comment

Choose a reason for hiding this comment

diegoferigo commented May 20, 2024

traversaro commented May 20, 2024

flferretti commented May 20, 2024 • edited Loading

traversaro commented May 20, 2024

flferretti commented May 20, 2024

traversaro commented May 20, 2024

flferretti commented May 20, 2024 • edited Loading

traversaro commented May 20, 2024

diegoferigo commented May 20, 2024

flferretti commented May 20, 2024

flferretti commented May 20, 2024 • edited Loading

traversaro commented May 20, 2024

flferretti commented May 20, 2024

flferretti commented May 20, 2024

diegoferigo commented May 20, 2024

flferretti commented May 20, 2024

github-actions bot commented May 20, 2024

flferretti commented May 20, 2024

diegoferigo commented May 20, 2024

github-actions bot commented May 20, 2024

diegoferigo commented May 20, 2024

flferretti commented May 20, 2024

diegoferigo left a comment

Choose a reason for hiding this comment

diegoferigo commented May 20, 2024 • edited Loading

flferretti commented May 20, 2024 • edited Loading

Bump Python version to 3.10 and add `gazebo` dependencies #8

Bump Python version to 3.10 and add `gazebo` dependencies #8

flferretti commented May 18, 2024 •

edited

Loading

flferretti commented May 20, 2024 •

edited

Loading

flferretti commented May 20, 2024 •

edited

Loading

flferretti commented May 20, 2024 •

edited

Loading

diegoferigo commented May 20, 2024 •

edited

Loading

flferretti commented May 20, 2024 •

edited

Loading