fix: add deprecation notice for win 32-bit #18130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
flotwig
requested review from
jennifer-shehane and
kuceb
and removed request for
a team
lmiller1990
reviewed
Sep 17, 2021
lmiller1990
previously approved these changes
Sep 20, 2021
|
LGTM! I don't have a 32 bit windows machine to actually test this on, if someone does, that'd be great. |
jennifer-shehane
requested changes
Sep 20, 2021
There was a problem hiding this comment.
We'll also need a PR against services for the https://on.cypress.io/win32-removal link
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
jennifer-shehane
approved these changes
Sep 21, 2021
tgriesser
added a commit
that referenced
this pull request
Sep 24, 2021
…/remove-decorators * unified-desktop-gui: fixing broken ct tests fix types remove old code chore: bump deps (#18213) feat(app): icon library supporting Cy's custom icons (#18195) feat(app): adding navigation, pages, router, and layout (#18194) chore: Update Chrome (stable) to 94.0.4606.54 (#18196) chore: bump yarn.lock (#18204) chore(tests): fix flake in net stubbing/xhr/proxy logging tests (#18163) chore: Update Chrome (beta) to 94.0.4606.54 (#18174) fix: add deprecation notice for win 32-bit (#18130) chore: fix broken firefox focus tests, bump resource class of chrome-beta job (#18133) fix(cli): Respect NO_PROXY on cypress download (#17702) chore: Update Chrome (beta) to 94.0.4606.50 (#18117) release 8.4.1 [skip ci] fix: GH env variable for test other projects (#18147) fix(open_project): remove unnecessary fn wrapping from tryToCalls (#18146) change @ts-expect-error -> @ts-ignore (#18047)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Additional details
How has the user experience changed?
warning for users on 32-bit windows:
warning for users on 64-bit windows:
same warning in runmode:
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?