LibTest/io/WebSocket/length_A01_t01.dart is flaky seemingly due to length future racing with socket closure
#2879
Assignees
Labels
bad-test
Report tests in need of updates. When closed, the tests should be considered good
Comments
sgrekhov
added
the
bad-test
sgrekhov
added a commit
to sgrekhov/co19
that referenced
this issue
Sep 16, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this issue
Sep 27, 2024
2024-09-26 sgrekhov22@gmail.com dart-lang/co19#2846. Add syntax and whitespaces tests (dart-lang/co19#2896) 2024-09-26 sgrekhov22@gmail.com Fixes dart-lang/co19#2892. Change expected errors positions. (dart-lang/co19#2894) 2024-09-26 sgrekhov22@gmail.com Fixes dart-lang/co19#2893. In case of ambiguous export don't expect an error on the first export (dart-lang/co19#2895) 2024-09-26 sgrekhov22@gmail.com dart-lang/co19#2846. Add static semantics tests for unquoted imports (dart-lang/co19#2891) 2024-09-25 sgrekhov22@gmail.com dart-lang/co19#2846. Add unquoted imports tests for path separator (dart-lang/co19#2889) 2024-09-25 sgrekhov22@gmail.com dart-lang/co19#2846. Add unquoted imports tests for parts (dart-lang/co19#2890) 2024-09-24 sgrekhov22@gmail.com dart-lang/co19#2559. Update `defining_augmentation_*` tests (dart-lang/co19#2884) 2024-09-24 sgrekhov22@gmail.com dart-lang/co19#2825. Add more grammar tests (dart-lang/co19#2882) 2024-09-24 sgrekhov22@gmail.com Fixes dart-lang/co19#2878. Use pid for unique temp name (dart-lang/co19#2883) 2024-09-24 sgrekhov22@gmail.com Fixes dart-lang/co19#2877. Catch and ignore exceptions during temp file deletion (dart-lang/co19#2881) 2024-09-24 sgrekhov22@gmail.com Fixes dart-lang/co19#2879. Fix racy code in length_A01_t01.dart (dart-lang/co19#2880) 2024-09-23 sgrekhov22@gmail.com dart-lang/co19#2846. Add unquoted imports tests for keywords (dart-lang/co19#2886) 2024-09-23 sgrekhov22@gmail.com Fixes dart-lang/co19#2887. Fix border type in static_analysis_extension_types_A08_t11.dart (dart-lang/co19#2888) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: Ibf63f6246db950981a0ee445764f9625bb69a9f0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387161 Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The test seems to expect
co19/LibTest/io/WebSocket/length_A01_t01.dart
Line 30 in baa1dd9
lengthFuture will get resolved before websocket gets closed.This seems to be racy.
The text was updated successfully, but these errors were encountered: