Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2825. Add more grammar tests #2882

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I did comment on a real nit, though: A missing article in many similar positions.

LanguageFeatures/Parts-with-imports/grammar_A02_t01.dart Outdated Show resolved Hide resolved
@sgrekhov
Copy link
Contributor Author

Updated. PTAL

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit eb7af0a into dart-lang:master Sep 24, 2024
1 of 2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Sep 27, 2024
2024-09-26 sgrekhov22@gmail.com dart-lang/co19#2846. Add syntax and whitespaces tests (dart-lang/co19#2896)
2024-09-26 sgrekhov22@gmail.com Fixes dart-lang/co19#2892. Change expected errors positions. (dart-lang/co19#2894)
2024-09-26 sgrekhov22@gmail.com Fixes dart-lang/co19#2893. In case of ambiguous export don't expect an error on the first export (dart-lang/co19#2895)
2024-09-26 sgrekhov22@gmail.com dart-lang/co19#2846. Add static semantics tests for unquoted imports (dart-lang/co19#2891)
2024-09-25 sgrekhov22@gmail.com dart-lang/co19#2846. Add unquoted imports tests for path separator (dart-lang/co19#2889)
2024-09-25 sgrekhov22@gmail.com dart-lang/co19#2846. Add unquoted imports tests for parts (dart-lang/co19#2890)
2024-09-24 sgrekhov22@gmail.com dart-lang/co19#2559. Update `defining_augmentation_*` tests (dart-lang/co19#2884)
2024-09-24 sgrekhov22@gmail.com dart-lang/co19#2825. Add more grammar tests (dart-lang/co19#2882)
2024-09-24 sgrekhov22@gmail.com Fixes dart-lang/co19#2878. Use pid for unique temp name (dart-lang/co19#2883)
2024-09-24 sgrekhov22@gmail.com Fixes dart-lang/co19#2877. Catch and ignore exceptions during temp file deletion (dart-lang/co19#2881)
2024-09-24 sgrekhov22@gmail.com Fixes dart-lang/co19#2879. Fix racy code in length_A01_t01.dart (dart-lang/co19#2880)
2024-09-23 sgrekhov22@gmail.com dart-lang/co19#2846. Add unquoted imports tests for keywords (dart-lang/co19#2886)
2024-09-23 sgrekhov22@gmail.com Fixes dart-lang/co19#2887. Fix border type in static_analysis_extension_types_A08_t11.dart (dart-lang/co19#2888)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Ibf63f6246db950981a0ee445764f9625bb69a9f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387161
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants