Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2846. Add unquoted imports tests for path separator #2889

Merged
merged 4 commits into from
Sep 25, 2024
Merged

#2846. Add unquoted imports tests for path separator #2889

merged 4 commits into from
Sep 25, 2024

Conversation

sgrekhov
Copy link
Contributor

No description provided.

eernstg
eernstg reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of comments this time. ;-)

I think it's necessary to start with the specified semantics and test that we have that, and then basically drop the idea that we can "test that '.' isn't used as a path separator".

LanguageFeatures/Unquoted-imports/path_separator_A01_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/Unquoted-imports/path_separator_A01_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/Unquoted-imports/test.package1/dummy.dart Outdated Show resolved Hide resolved
LanguageFeatures/Unquoted-imports/test.package1/lib/dotted.name1.dart Outdated

// SharedOptions=--enable-experiment=unquoted-imports

String libraryId = "dotted.name1.dart";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps?:

Suggested change
String libraryId = "dotted.name1.dart";
String libraryId = "dotted.name11";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why dotted.name11? Changed to dotted.name1.

Copy link
Member

@eernstg eernstg Sep 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked at the other declarations playing a similar role: It looked like the libraryId would be created by removing .dart from the end of the file name and adding 1, e.g., c.d.dart has 'c.d1'.

LanguageFeatures/Unquoted-imports/test.package1/lib/package1.dart Outdated Show resolved Hide resolved
LanguageFeatures/Unquoted-imports/test.package1/lib/test.package1.dart Outdated Show resolved Hide resolved
LanguageFeatures/Unquoted-imports/test_package2/dummy.dart Outdated Show resolved Hide resolved
LanguageFeatures/Unquoted-imports/test_package2/lib/dotted.name2.dart Outdated Show resolved Hide resolved
LanguageFeatures/Unquoted-imports/test_package2/lib/test_package2.dart Outdated Show resolved Hide resolved
sgrekhov
sgrekhov commented Sep 24, 2024
View reviewed changes
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. path_separator_* tests removed at all. I'll add static_semantics_* tests in a separate PR later. PTAL

LanguageFeatures/Unquoted-imports/path_separator_A01_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/Unquoted-imports/path_separator_A01_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/Unquoted-imports/test.package1/dummy.dart Outdated Show resolved Hide resolved
LanguageFeatures/Unquoted-imports/test.package1/lib/dotted.name1.dart Outdated

// SharedOptions=--enable-experiment=unquoted-imports

String libraryId = "dotted.name1.dart";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why dotted.name11? Changed to dotted.name1.

LanguageFeatures/Unquoted-imports/test.package1/lib/package1.dart Outdated Show resolved Hide resolved
LanguageFeatures/Unquoted-imports/test.package1/lib/test.package1.dart Outdated Show resolved Hide resolved
LanguageFeatures/Unquoted-imports/test_package2/dummy.dart Outdated Show resolved Hide resolved
LanguageFeatures/Unquoted-imports/test_package2/lib/dotted.name2.dart Outdated Show resolved Hide resolved
@sgrekhov
Copy link
Contributor Author

Merge conflict has been resolved. PTAL.

eernstg
eernstg approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 15a5822 into dart-lang:master Sep 25, 2024
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Sep 27, 2024
@sgrekhov
[co19] Roll co19 to 8d0c6ae63cdb788e121dace91c338c4453d22010
8076595 
2024-09-26 sgrekhov22@gmail.com dart-lang/co19#2846. Add syntax and whitespaces tests (dart-lang/co19#2896)
2024-09-26 sgrekhov22@gmail.com Fixes dart-lang/co19#2892. Change expected errors positions. (dart-lang/co19#2894)
2024-09-26 sgrekhov22@gmail.com Fixes dart-lang/co19#2893. In case of ambiguous export don't expect an error on the first export (dart-lang/co19#2895)
2024-09-26 sgrekhov22@gmail.com dart-lang/co19#2846. Add static semantics tests for unquoted imports (dart-lang/co19#2891)
2024-09-25 sgrekhov22@gmail.com dart-lang/co19#2846. Add unquoted imports tests for path separator (dart-lang/co19#2889)
2024-09-25 sgrekhov22@gmail.com dart-lang/co19#2846. Add unquoted imports tests for parts (dart-lang/co19#2890)
2024-09-24 sgrekhov22@gmail.com dart-lang/co19#2559. Update `defining_augmentation_*` tests (dart-lang/co19#2884)
2024-09-24 sgrekhov22@gmail.com dart-lang/co19#2825. Add more grammar tests (dart-lang/co19#2882)
2024-09-24 sgrekhov22@gmail.com Fixes dart-lang/co19#2878. Use pid for unique temp name (dart-lang/co19#2883)
2024-09-24 sgrekhov22@gmail.com Fixes dart-lang/co19#2877. Catch and ignore exceptions during temp file deletion (dart-lang/co19#2881)
2024-09-24 sgrekhov22@gmail.com Fixes dart-lang/co19#2879. Fix racy code in length_A01_t01.dart (dart-lang/co19#2880)
2024-09-23 sgrekhov22@gmail.com dart-lang/co19#2846. Add unquoted imports tests for keywords (dart-lang/co19#2886)
2024-09-23 sgrekhov22@gmail.com Fixes dart-lang/co19#2887. Fix border type in static_analysis_extension_types_A08_t11.dart (dart-lang/co19#2888)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Ibf63f6246db950981a0ee445764f9625bb69a9f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387161
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgrekhov @eernstg