Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Tasks for TaskResult, TaskOption, and TaskResultOption. #169

Merged
merged 11 commits into from
Mar 30, 2022

Conversation

TheAngryByrd
Copy link
Collaborator

@TheAngryByrd TheAngryByrd commented Mar 29, 2022

Proposed Changes

Closes #142

Types of changes

What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an x in the boxes that apply

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

To make all the existing tests to pass. I had to implement my own versions of While and Combine as described by BDFN.

Testing the Dynamic path isn't easy currently. Commenting out the state machine part of Run and delegating directly to RunDynamic is how I tested some implementations. The only other way I've seen is implement additional CE's and force it to not inline the state machine.

I implemented backgroundTaskResult and backgroundTaskOption but I haven't added tests around them. Tests have been added and I've implemented a corresponding version using Ply in the netstandard2.0 TFM.

taskResultOption is implemented in the laziest way possible by re-using the native Task resumption code. This now uses it's own resumable code implemenation.

@TheAngryByrd TheAngryByrd changed the title 142 native tasks Native Tasks for TaskResult, TaskOption, and TaskResultOption. Mar 30, 2022
Adds tests for backgroundTaskResultCE. Adds a Ply compatible version
@TheAngryByrd TheAngryByrd marked this pull request as ready for review March 30, 2022 10:14
@TheAngryByrd
Copy link
Collaborator Author

While I haven't figured out the best way yet to test the Dynamic path, i'm going to merge this to get feedback from people in the field.

@TheAngryByrd TheAngryByrd merged commit 78d9daa into master Mar 30, 2022
TheAngryByrd added a commit that referenced this pull request Mar 30, 2022
- [Moves many functions to inline with InlineIfLambda for performance](#166) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
- [Native Tasks for TaskResult, TaskOption, and TaskResultOption](#169) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
TheAngryByrd added a commit that referenced this pull request Apr 5, 2022
- [Moves many functions to inline with InlineIfLambda for performance](#166) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
- [Native Tasks for TaskResult, TaskOption, and TaskResultOption](#169) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
- [Add explicit type parameters to ignore functions](#174) Credits [@cmeeren](https://github.com/cmeeren)
TheAngryByrd added a commit that referenced this pull request Apr 5, 2022
- [Moves many functions to inline with InlineIfLambda for performance](#166) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
- [Native Tasks for TaskResult, TaskOption, and TaskResultOption](#169) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
- [Add explicit type parameters to ignore functions](#174) Credits [@cmeeren](https://github.com/cmeeren)
- [Adds CancellableTaskResult](#172) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
TheAngryByrd added a commit that referenced this pull request Apr 5, 2022
- [Moves many functions to inline with InlineIfLambda for performance](#166) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
- [Native Tasks for TaskResult, TaskOption, and TaskResultOption](#169) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
- [Add explicit type parameters to ignore functions](#174) Credits [@cmeeren](https://github.com/cmeeren)
- [Adds CancellableTaskResult](#172) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
TheAngryByrd added a commit that referenced this pull request Apr 15, 2022
- [Moves many functions to inline with InlineIfLambda for performance](#166) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
- [Native Tasks for TaskResult, TaskOption, and TaskResultOption](#169) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
- [Add explicit type parameters to ignore functions](#174) Credits [@cmeeren](https://github.com/cmeeren)
- [Adds CancellableTaskResult](#172) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
- [Fixes TaskResultCE breaking with a bind in branching such as if](#177)  Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
@cmeeren
Copy link
Contributor

cmeeren commented Apr 29, 2022

Since taskResult and friends now (I assume) requires no dependencies, is there any good reason to have them in a separate package? Couldn't they be integrated into the main package?

@TheAngryByrd
Copy link
Collaborator Author

TheAngryByrd commented Apr 29, 2022

I address some of this here:

#175 (comment)

additionally, we still do have Ply as a dependency for older .net versions still around so I’d rather kept them together in the codebase.

@cmeeren
Copy link
Contributor

cmeeren commented Apr 29, 2022

Got it, thanks!

@TheAngryByrd TheAngryByrd deleted the 142-native-tasks branch July 12, 2022 14:43
TheAngryByrd added a commit that referenced this pull request Oct 14, 2022
- [Fixing stackoverflows in large while loops](#182) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
- [Moves many functions to inline with InlineIfLambda for performance](#166) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
- [Native Tasks for TaskResult, TaskOption, and TaskResultOption](#169) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
- [Add explicit type parameters to ignore functions](#174) Credits [@cmeeren](https://github.com/cmeeren)
- [Adds CancellableTaskResult](#172) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
- [Fixes TaskResultCE breaking with a bind in branching such as if](#177)  Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native tasks
2 participants