-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit type parameters to ignore functions #174
Merged
TheAngryByrd
merged 2 commits into
demystifyfp:master
from
cmeeren:ignore-explicit-type-parameters
Apr 5, 2022
Merged
Add explicit type parameters to ignore functions #174
TheAngryByrd
merged 2 commits into
demystifyfp:master
from
cmeeren:ignore-explicit-type-parameters
Apr 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
requested changes
Apr 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I think this just needs a ./build.sh FormatCode
and it should be all good!
Done! |
TheAngryByrd
added a commit
that referenced
this pull request
Apr 5, 2022
- [Moves many functions to inline with InlineIfLambda for performance](#166) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Native Tasks for TaskResult, TaskOption, and TaskResultOption](#169) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Add explicit type parameters to ignore functions](#174) Credits [@cmeeren](https://github.com/cmeeren)
TheAngryByrd
added a commit
that referenced
this pull request
Apr 5, 2022
- [Moves many functions to inline with InlineIfLambda for performance](#166) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Native Tasks for TaskResult, TaskOption, and TaskResultOption](#169) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Add explicit type parameters to ignore functions](#174) Credits [@cmeeren](https://github.com/cmeeren) - [Adds CancellableTaskResult](#172) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
TheAngryByrd
added a commit
that referenced
this pull request
Apr 5, 2022
- [Moves many functions to inline with InlineIfLambda for performance](#166) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Native Tasks for TaskResult, TaskOption, and TaskResultOption](#169) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Add explicit type parameters to ignore functions](#174) Credits [@cmeeren](https://github.com/cmeeren) - [Adds CancellableTaskResult](#172) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
TheAngryByrd
added a commit
that referenced
this pull request
Apr 15, 2022
- [Moves many functions to inline with InlineIfLambda for performance](#166) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Native Tasks for TaskResult, TaskOption, and TaskResultOption](#169) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Add explicit type parameters to ignore functions](#174) Credits [@cmeeren](https://github.com/cmeeren) - [Adds CancellableTaskResult](#172) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Fixes TaskResultCE breaking with a bind in branching such as if](#177) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
TheAngryByrd
added a commit
that referenced
this pull request
Oct 14, 2022
- [Fixing stackoverflows in large while loops](#182) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Moves many functions to inline with InlineIfLambda for performance](#166) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Native Tasks for TaskResult, TaskOption, and TaskResultOption](#169) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Add explicit type parameters to ignore functions](#174) Credits [@cmeeren](https://github.com/cmeeren) - [Adds CancellableTaskResult](#172) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Fixes TaskResultCE breaking with a bind in branching such as if](#177) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173
If anything needs fixing, feel free to make any edits you want, or merge and fix up later, or anything, really. 🙂 I have no particular desire to own this change.