Fixing while loops #182
Merged
Fixing while loops #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
force-pushed
the
fixing-while-loops
branch
from
cfd1d87
to
c4ecf2f
Compare
|
Interesting, the bigger while loops are extremely slow on fable/node/windows but seem ok on linux/mac. Windows : |
TheAngryByrd
added a commit
that referenced
this pull request
Oct 14, 2022
- [Fixing stackoverflows in large while loops](#182) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
TheAngryByrd
added a commit
that referenced
this pull request
Oct 14, 2022
- [Fixing stackoverflows in large while loops](#182) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Moves many functions to inline with InlineIfLambda for performance](#166) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Native Tasks for TaskResult, TaskOption, and TaskResultOption](#169) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Add explicit type parameters to ignore functions](#174) Credits [@cmeeren](https://github.com/cmeeren) - [Adds CancellableTaskResult](#172) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - [Fixes TaskResultCE breaking with a bind in branching such as if](#177) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Many of the while loops have been broken, this puts tests i place and fixes the CEs that were broke.
Types of changes
What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an
xin the boxes that apply and remove ones that don't applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...