Refactor Client Code, part 2 of several #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonforster
requested review from
michaelestrin,
tsconn23 and
AnthonyMBonafide
brandonforster
commented
Jan 9, 2020
| } | ||
|
|
||
| // Helper method to request and decode a device service | ||
| func (s *deviceServiceRestClient) requestDeviceService(url string, ctx context.Context) (models.DeviceService, error) { |
There was a problem hiding this comment.
I removed this helper method because it is only used once and is unlikely to be used anywhere else.
michaelestrin
suggested changes
Jan 10, 2020
Signed-off-by: Brandon Forster <brandonforster@gmail.com>
Renamed EndpointerClient to Client. Signed-off-by: Michael W. Estrin <me@michaelestrin.com>
Signed-off-by: Michael W. Estrin <me@michaelestrin.com>
Refactored client implementation to strategy pattern. Updated package to only expose public Factory function. Signed-off-by: Michael W. Estrin <me@michaelestrin.com>
… here). Signed-off-by: Michael W. Estrin <me@michaelestrin.com>
Signed-off-by: Brandon Forster <brandonforster@gmail.com>
Signed-off-by: Brandon Forster <brandonforster@gmail.com>
Signed-off-by: Brandon Forster <brandonforster@gmail.com>
Signed-off-by: Brandon Forster <me@brandonforster.com>
Signed-off-by: Brandon Forster <me@brandonforster.com>
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster
force-pushed
the
endpoint_metadata
branch
from
d0c3967
to
96dd8e2
Compare
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 48.01% 48.39% +0.38%
==========================================
Files 61 64 +3
Lines 2347 2093 -254
==========================================
- Hits 1127 1013 -114
+ Misses 1146 1002 -144
- Partials 74 78 +4
Continue to review full report at Codecov.
|
Signed-off-by: Brandon Forster <me@brandonforster.com>
Signed-off-by: Brandon Forster <me@brandonforster.com>
Signed-off-by: Brandon Forster <brandonforster@gmail.com>
Signed-off-by: Brandon Forster <me@brandonforster.com>
Signed-off-by: Brandon Forster <brandonforster@gmail.com>
brandonforster
force-pushed
the
endpoint_metadata
branch
from
96dd8e2
to
c9aeac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the second part of several working on #196.
This PR refactors all of metadata's clients and updates their unit tests.
To test, actuate the endpoints in the metadata device client. The blackbox tests for command should work for that.