Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Client Code, part 2 of several #197

Merged
merged 16 commits into from
Jan 16, 2020
Merged

Refactor Client Code, part 2 of several #197

merged 16 commits into from
Jan 16, 2020

Commits on Jan 13, 2020

  1. Added EndpointClient struct, updated device.go to use it. 

    Signed-off-by: Brandon Forster <brandonforster@gmail.com>
    @brandonforster
    brandonforster committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    377025b View commit details
    Browse the repository at this point in the history

  2. Moved/renamed endpointer.go to common/client.go. 

    Renamed EndpointerClient to Client.

Signed-off-by: Michael W. Estrin <me@michaelestrin.com>
    @michaelestrin @brandonforster
    michaelestrin authored and brandonforster committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    32207f2 View commit details
    Browse the repository at this point in the history

  3. Extracted timeout from URL signature into NewClient factory function. 

    Signed-off-by: Michael W. Estrin <me@michaelestrin.com>
    @michaelestrin @brandonforster
    michaelestrin authored and brandonforster committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    d1658f5 View commit details
    Browse the repository at this point in the history

  4. Moved common client into own package. 

    Refactored client implementation to strategy pattern.

Updated package to only expose public Factory function.

Signed-off-by: Michael W. Estrin <me@michaelestrin.com>
    @michaelestrin @brandonforster
    michaelestrin authored and brandonforster committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    33ee5c4 View commit details
    Browse the repository at this point in the history

  5. Naming change and consolidated some common code (more work to be done… 

    … here).

Signed-off-by: Michael W. Estrin <me@michaelestrin.com>
    @michaelestrin @brandonforster
    michaelestrin authored and brandonforster committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    2d3a773 View commit details
    Browse the repository at this point in the history

  6. Added missing test for device profile using Consul 

    Signed-off-by: Brandon Forster <brandonforster@gmail.com>
    @brandonforster
    brandonforster committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    f928ff0 View commit details
    Browse the repository at this point in the history

  7. Renamed clent contract to something more descriptive. Added GoDoc. 

    Signed-off-by: Brandon Forster <brandonforster@gmail.com>
    @brandonforster
    brandonforster committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    ace66c9 View commit details
    Browse the repository at this point in the history

  8. Renamed most types introduced in this work and filled out GoDoc. 

    Signed-off-by: Brandon Forster <brandonforster@gmail.com>
    @brandonforster
    brandonforster committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    f670b36 View commit details
    Browse the repository at this point in the history

  9. Added unit test classes. Renamed classes. Wrote factory unit test. 

    Signed-off-by: Brandon Forster <me@brandonforster.com>
    @brandonforster
    brandonforster committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    520d788 View commit details
    Browse the repository at this point in the history

  10. Added local client tests. 

    Signed-off-by: Brandon Forster <me@brandonforster.com>
    @brandonforster
    brandonforster committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    7e20034 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. Added tests for metadata clients. 

    Signed-off-by: Brandon Forster <me@brandonforster.com>
    @brandonforster
    brandonforster committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    1eddd5e View commit details
    Browse the repository at this point in the history

  2. Updated tests. Updated names to be idiomatic. 

    Signed-off-by: Brandon Forster <me@brandonforster.com>
    @brandonforster
    brandonforster committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    4478da7 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2020

  1. Added tests for metadata clients. 

    Signed-off-by: Brandon Forster <me@brandonforster.com>
    @brandonforster
    brandonforster committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    ab84fcc View commit details
    Browse the repository at this point in the history

  2. edgexfoundry#196: Refactor metadata clients. 

    Signed-off-by: Brandon Forster <brandonforster@gmail.com>
    @brandonforster
    brandonforster committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    5aa1de2 View commit details
    Browse the repository at this point in the history

  3. Updated with changes from edgexfoundry#195 

    Signed-off-by: Brandon Forster <me@brandonforster.com>
    @brandonforster
    brandonforster committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    3e166d3 View commit details
    Browse the repository at this point in the history

  4. Updated with changes from edgexfoundry#195. 

    Signed-off-by: Brandon Forster <brandonforster@gmail.com>
    @brandonforster
    brandonforster committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    c9aeac5 View commit details
    Browse the repository at this point in the history