Refactor Client Code, part 3/7: core-data #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Forster <me@brandonforster.com>
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster
requested review from
michaelestrin,
tsconn23 and
lenny-goodell
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 48.39% 45.96% -2.44%
==========================================
Files 64 64
Lines 2093 2145 +52
==========================================
- Hits 1013 986 -27
- Misses 1002 1074 +72
- Partials 78 85 +7
Continue to review full report at Codecov.
|
michaelestrin
suggested changes
Jan 18, 2020
Signed-off-by: Brandon Forster <me@brandonforster.com>
|
recheck |
brandonforster
changed the title
michaelestrin
suggested changes
Jan 21, 2020
Signed-off-by: Brandon Forster <me@brandonforster.com>
|
@michaelestrin let me know if this looks good and if so, I'll kick off the rebase cascade and update the names of the URL variables to urlPrefix. |
Signed-off-by: Brandon Forster <me@brandonforster.com>
michaelestrin
approved these changes
Jan 23, 2020
michaelestrin
pushed a commit
that referenced
this pull request
Jan 23, 2020
|
PR content included in #202. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the third part of several working on #196.
This PR refactors all of core-data's clients and updates their unit tests.
To test, actuate the endpoints in the core-data REST client.