Refactor Client Code, part 6/7: notifications #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Forster <me@brandonforster.com>
Signed-off-by: Brandon Forster <me@brandonforster.com>
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster
requested review from
michaelestrin,
tsconn23 and
AnthonyMBonafide
michaelestrin
suggested changes
Jan 21, 2020
clients/general/client.go
Outdated
| } else { | ||
| gc.url = params.Url | ||
| func (gc *generalRestClient) FetchConfiguration(ctx context.Context) (string, error) { | ||
| url, err := gc.urlClient.Prefix() |
There was a problem hiding this comment.
Variable naming in prior PRs is urlPrefix; rename url here for consistency. Applies to any/all calls to Prefix().
Signed-off-by: Brandon Forster <me@brandonforster.com>
Signed-off-by: Brandon Forster <me@brandonforster.com>
Signed-off-by: Brandon Forster <me@brandonforster.com>
Signed-off-by: Brandon Forster <me@brandonforster.com>
Signed-off-by: Brandon Forster <me@brandonforster.com>
Signed-off-by: Brandon Forster <me@brandonforster.com>
Signed-off-by: Brandon Forster <me@brandonforster.com>
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster
force-pushed
the
issue_196_notification
branch
from
35cccae
to
69f0ac3
Compare
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
- Coverage 48.39% 45.85% -2.55%
==========================================
Files 64 64
Lines 2093 2133 +40
==========================================
- Hits 1013 978 -35
- Misses 1002 1066 +64
- Partials 78 89 +11
Continue to review full report at Codecov.
|
michaelestrin
approved these changes
Jan 23, 2020
michaelestrin
pushed a commit
that referenced
this pull request
Jan 23, 2020
|
PR content included in #202. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the sixth part of several working on #196.
This PR refactors all of notification's client methods.