[Ingest Pipelines] Fix accessibility tests #164341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonelizabeth
commented
Aug 21, 2023
| @@ -29,7 +28,7 @@ export default function ({ getService, getPageObjects }: any) { | |||
| await a11y.testAppSnapshot(); | |||
| }); | |||
|
|
|||
| it('List View', async () => { | |||
| it('Details View', async () => { | |||
There was a problem hiding this comment.
Fixing test description
alisonelizabeth
commented
Aug 21, 2023
| @@ -50,8 +49,7 @@ export default function ({ getService, getPageObjects }: any) { | |||
| }); | |||
|
|
|||
| it('Create Pipeline Wizard', async () => { | |||
| await testSubjects.click('emptyStateCreatePipelineDropdown'); | |||
| await testSubjects.click('emptyStateCreatePipelineButton'); | |||
| await common.navigateToUrl('ingestPipelines', 'create', { shouldUseHashForSubUrl: false }); | |||
There was a problem hiding this comment.
The previous code was failing bc it was expecting the create button from the empty state view. Rather than depending on pipelines to exist/not exist, we navigate directly to the create page.
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
alisonelizabeth
added
Team:Kibana Management
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
ElenaStoeva
approved these changes
Aug 23, 2023
kibanamachine
added
v8.11.0
backport:skip
wayneseymour
added a commit
to wayneseymour/kibana
that referenced
this pull request
Oct 11, 2024
Contributes to: elastic#194817 Why I assigned them: Assigned advanced_settings due to elastic#175255 Assigned dashboard_controls due to elastic#190797 Assigned dashboard_links due to elastic#174772 Assigned dashboard_panel_options due to elastic#178596 Assigned grok_debugger due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned helpers due to elastic#164341 (call site) Assigned home due to elastic#103192 Assigned index_lifecycle_management due to elastic#116207 Assigned ingest_node_pipelines due to elastic#113783 Assigned kibana_overview due to https://github.com/elastic/kibana/blob/f00ac7a8a21463e6bb4a2784c3a3884f36c62900/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned management due to elastic#165705 Assigned painless_lab due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/painless_lab/kibana.jsonc#L4 Assigned search_profiler due to elastic#195343 Assigned uptime due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/uptime/kibana.jsonc#L4 Assigned lens due to elastic#175893 Assigned ml_anomaly_detection due to elastic#162126 Assigned canvas due to elastic#164376 Assigned cc replication due to elastic#149069 Assigned enterpise search due to elastic#79359 Assigned graph to due elastic#190797 Assigned license_management due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/license_management/kibana.jsonc#L4 Assigned maps due to elastic#155161 Assigned observability due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability/kibana.jsonc#L4 Assigned remote clusters due to elastic#96989 Assigned reporting due to elastic#121435 Assigned rollup_jobs due to https://github.com/elastic/kibana/blob/d57bc9a5d7d64f86b550eff7997605a3090aee9a/x-pack/plugins/rollup/kibana.jsonc#L4 Assigned watcher due to elastic#119717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unskips the accessibility tests for Ingest Pipelines UI.
Fixes #157512
Fixes #155928