[Dashboard] Remove library and drilldown notifications #190797

cqliu1 · 2024-08-20T13:36:42Z

Summary

Pre-req for #182535.

We're removing the linked to library and drilldown notifications as part of the panel hover actions redesign which gets rid of the title bar in edit mode. We want to prevent panels from having a title bar when titles are hidden and believe these notifications are no longer necessary. The only notification retained is the panel filter notification.

I also did some cleanup and removed unused page objects from the vis, dashboard, and discover functional tests.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2024-08-20T13:36:44Z

Pinging @elastic/kibana-presentation (Team:Presentation)

cqliu1 · 2024-08-20T15:24:57Z

/ci

nickofthyme

Vis changes LGTM 🎉

…rd/remove-library-notification

nickpeihl

lgtm! I left a couple nits, but nothing that has to block merging this.

code review and tested changes to notifications.

nickpeihl · 2024-08-26T17:31:08Z

test/functional/apps/dashboard_elements/links/links_create_edit.ts

@@ -76,7 +76,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
        await common.waitForSaveModalToClose();
        await testSubjects.exists('addObjectToDashboardSuccess');
        await testSubjects.existOrFail('links--component');
-        await testSubjects.existOrFail('embeddablePanelNotification-ACTION_LIBRARY_NOTIFICATION');
+        await dashboardPanelActions.expectLinkedToLibrary(LINKS_PANEL_NAME);


💯 this assertion is much better now.

nickpeihl · 2024-08-26T17:41:27Z

test/functional/services/dashboard/panel_actions.ts

+  async legacyUnlinkFromLibraryByTitle(title = '') {
+    this.log.debug(`legacyUnlinkFromLibraryByTitle(${title}`);
+    const header = await this.getPanelHeading(title);
+    await this.legacyUnlinkFromLibrary(header);


nit, should we move the await this.clickContextMenuItem(LEGACY_UNLINK_FROM_LIBRARY_TEST_SUBJ, parent); line from legacyUnlinkFromLibrary into this method? Then I think we could get rid of legacyUnlinkFromLibrary completely.

I think what I'll do here is have all of the panel actions helpers receive title strings instead of header web elements

nickpeihl · 2024-08-26T17:42:58Z

test/functional/services/dashboard/panel_actions.ts

+  async unlinkFromLibraryByTitle(title = '') {
+    this.log.debug(`unlinkFromLibraryByTitle(${title})`);
+    const header = await this.getPanelHeading(title);
+    await this.unlinkFromLibrary(header);


nit, same comment as above. It seems unnecessary to keep the unlinkFromLibrary method that only has a single line.

nickpeihl · 2024-08-26T17:53:48Z

x-pack/test/functional/apps/dashboard/group2/panel_titles.ts

@@ -88,7 +81,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
      });
    });

-    describe('nick by reference', () => {


😢 ~~nick~~ 😛

…rd/remove-library-notification

kibana-ci · 2024-09-09T21:09:41Z

💚 Build Succeeded

Buildkite Build
Commit: 2d78569

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`dashboard`	564	561	-3
`embeddableEnhanced`	45	44	-1
total			-4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dashboard`	461.2KB	457.5KB	-3.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`embeddableEnhanced`	10.7KB	8.9KB	-1.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cqliu1

## Summary Pre-req for elastic#182535. We're removing the linked to library and drilldown notifications as part of the panel hover actions redesign which gets rid of the title bar in edit mode. We want to prevent panels from having a title bar when titles are hidden and believe these notifications are no longer necessary. The only notification retained is the panel filter notification. <img width="421" alt="Screenshot 2024-08-20 at 6 34 16 AM" src="https://github.com/user-attachments/assets/9f954a6f-3a70-43c9-a3c3-28f92f1efba8"> <img width="269" alt="Screenshot 2024-08-20 at 6 37 18 AM" src="https://github.com/user-attachments/assets/b6c154d5-0b8c-4c8b-ac72-a190d03f8801"> I also did some cleanup and removed unused page objects from the vis, dashboard, and discover functional tests. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

Contributes to: elastic#194817 Why I assigned them: Assigned advanced_settings due to elastic#175255 Assigned dashboard_controls due to elastic#190797 Assigned dashboard_links due to elastic#174772 Assigned dashboard_panel_options due to elastic#178596 Assigned grok_debugger due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned helpers due to elastic#164341 (call site) Assigned home due to elastic#103192 Assigned index_lifecycle_management due to elastic#116207 Assigned ingest_node_pipelines due to elastic#113783 Assigned kibana_overview due to https://github.com/elastic/kibana/blob/f00ac7a8a21463e6bb4a2784c3a3884f36c62900/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned management due to elastic#165705 Assigned painless_lab due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/painless_lab/kibana.jsonc#L4 Assigned search_profiler due to elastic#195343 Assigned uptime due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/uptime/kibana.jsonc#L4 Assigned lens due to elastic#175893 Assigned ml_anomaly_detection due to elastic#162126 Assigned canvas due to elastic#164376 Assigned cc replication due to elastic#149069 Assigned enterpise search due to elastic#79359 Assigned graph to due elastic#190797 Assigned license_management due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/license_management/kibana.jsonc#L4 Assigned maps due to elastic#155161 Assigned observability due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability/kibana.jsonc#L4 Assigned remote clusters due to elastic#96989 Assigned reporting due to elastic#121435 Assigned rollup_jobs due to https://github.com/elastic/kibana/blob/d57bc9a5d7d64f86b550eff7997605a3090aee9a/x-pack/plugins/rollup/kibana.jsonc#L4 Assigned watcher due to elastic#119717

Remove linked to library notification

405acd2

cqliu1 requested review from a team as code owners August 20, 2024 13:36

cqliu1 changed the title ~~[Dashboard] Remove linked to library notification~~ [Dashboard] Remove library and drilldown notifications Aug 20, 2024

cqliu1 added 3 commits August 20, 2024 07:05

Fix translations

3bf89fb

Remove panel notifications registration

052f9d9

Fix drilldown counter helper

8a39a07

botelastic bot added the Feature:Drilldowns Embeddable panel Drilldowns label Aug 20, 2024

nickofthyme approved these changes Aug 20, 2024

View reviewed changes

cqliu1 added 7 commits August 20, 2024 08:56

Fix circular dependency

33d14b7

Remove unused service

194f0f2

Remove unused page objects

9d8a734

Fix tests

2ccc2cc

Remove exclusive suite

8688cf1

Merge branch 'main' of https://github.com/elastic/kibana into dashboa…

9898429

…rd/remove-library-notification

Remove code

4f877b8

nickpeihl self-requested a review August 26, 2024 17:12

nickpeihl approved these changes Aug 26, 2024

View reviewed changes

cqliu1 added 2 commits August 26, 2024 15:40

Apply feedback

7dbea93

Merge branch 'main' into dashboard/remove-library-notification

82fe473

cqliu1 added 19 commits August 30, 2024 10:39

Fix lens test

6cefb0e

Fix expectLinkedToLibrary

d6963c0

Fix embeddable library test

b1fa6d3

Update panel drilldown actions

cf6284f

Merge branch 'main' of https://github.com/elastic/kibana into dashboa…

25cce7c

…rd/remove-library-notification

Fix click manage drilldown

901f421

Fix legacy vis library tests

395bd8c

Remove exclusive suite

4401259

Fix more tests

25c4c68

Fix more tests

84b163c

Fix time to visualize security

2b106f8

Fix tsvb test

01a150c

Merge branch 'main' of https://github.com/elastic/kibana into dashboa…

1943bb6

…rd/remove-library-notification

Merge branch 'main' of https://github.com/elastic/kibana into dashboa…

fbb010b

…rd/remove-library-notification

Merge branch 'main' of https://github.com/elastic/kibana into dashboa…

4ba8961

…rd/remove-library-notification

Fix merge conflict

5684a21

fix more tests

b38c495

Fix serverless tests

8094cf7

Remove duplicate service

2d78569

cqliu1 added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Sep 9, 2024

cqliu1 merged commit 3d8fad5 into elastic:main Sep 9, 2024
20 checks passed

kibanamachine added the backport:skip This commit does not require backporting label Sep 9, 2024

cqliu1 deleted the dashboard/remove-library-notification branch September 9, 2024 21:11

szaffarano mentioned this pull request Sep 13, 2024

[Telemetry][Security Solution] Fix integration tests on branch 9.0 #192842

Merged

1 task

nreese mentioned this pull request Sep 20, 2024

[Dashboard] embeddable filters are not displayed #193553

Closed

wayneseymour mentioned this pull request Oct 11, 2024

[FTR][Ownership] Assign ally/grps 1,2 & 3 #195964

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dashboard] Remove library and drilldown notifications #190797

[Dashboard] Remove library and drilldown notifications #190797

cqliu1 commented Aug 20, 2024 •

edited

Loading

elasticmachine commented Aug 20, 2024

cqliu1 commented Aug 20, 2024

nickofthyme left a comment

nickpeihl left a comment

nickpeihl Aug 26, 2024

nickpeihl Aug 26, 2024

cqliu1 Aug 26, 2024

nickpeihl Aug 26, 2024

nickpeihl Aug 26, 2024

kibana-ci commented Sep 9, 2024

[Dashboard] Remove library and drilldown notifications #190797

[Dashboard] Remove library and drilldown notifications #190797

Conversation

cqliu1 commented Aug 20, 2024 • edited Loading

Summary

Checklist

Risk Matrix

For maintainers

elasticmachine commented Aug 20, 2024

cqliu1 commented Aug 20, 2024

nickofthyme left a comment

Choose a reason for hiding this comment

nickpeihl left a comment

Choose a reason for hiding this comment

nickpeihl Aug 26, 2024

Choose a reason for hiding this comment

nickpeihl Aug 26, 2024

Choose a reason for hiding this comment

cqliu1 Aug 26, 2024

Choose a reason for hiding this comment

nickpeihl Aug 26, 2024

Choose a reason for hiding this comment

nickpeihl Aug 26, 2024

Choose a reason for hiding this comment

kibana-ci commented Sep 9, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

cqliu1 commented Aug 20, 2024 •

edited

Loading