[Dashboard] Reorganize panel actions #178596

cqliu1 · 2024-03-13T03:50:02Z

Summary

Closes #177254.

This updates the order panel actions appear in the actions menu. This also deletes the Replace panel action.

Top level

More

Changes:

Move create/manage drilldown actions into More sub-menu
Move Delete from dashboard onto the top level actions menu
Delete Replace panel action
Delete Add to new case action
Rename Add to existing case action -> Add to case
Rename Create anomaly detection job action -> Detect anomalies
Rename Clone panel action -> Duplicate
Rename Panel settings action -> Settings
Rename Delete from dashboard action -> Remove
Rename Explore data in Discover action -> Explore in Discover
Rename Download as CSV action -> Download CSV
Rename Maximize panel action -> Maximize

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

amyjtechwriter · 2024-03-20T19:38:47Z

Hey hey @cqliu1 , just looking at the words in the panel actions we could maybe change some.

Panel settings --> Settings
Clone panel --> Duplicate
Delete from dashboard --> Remove (If the user selects this and the panel is not saved in the viz library maybe we should introduce a modal to state it is permanently removed/deleted...but if we use the word deleted in the modal then perhaps we should stick with the original 'Delete from dashboard'. I'm struggling to make up my mind about it.)
Explore data in Discover --> Explore in Discover
Download as CSV --> Download CSV/Export CSV
Maximize panel --> Maximize

I think the other actions are good as they are because they are very descriptive. I won't be offended if we don't change any of the actions

cqliu1 · 2024-03-21T15:07:19Z

@teresaalvarezsoler Can we do this reorg without using the dividers in the More sub-menu? It will require a pretty significant refactor of the actions framework and take an additional week or so.

Here are Andrea's mocks with the dividers:

Here's what I've implemented on this PR so far:

teresaalvarezsoler · 2024-03-21T19:40:21Z

@cqliu1 absolutely, let's do it without dividers. This menu will anyway change when we do hover actions so let's keep it to the minimum possible effort for now.

elasticmachine · 2024-03-21T20:56:56Z

Pinging @elastic/kibana-presentation (Team:Presentation)

…fix'

jgowdyelastic · 2024-03-22T09:20:20Z

x-pack/plugins/ml/public/ui_actions/open_vis_in_ml_action.tsx

@@ -28,7 +28,7 @@ export function createVisToADJobAction(
    },
    getDisplayName: () =>
      i18n.translate('xpack.ml.actions.createADJobFromLens', {
-        defaultMessage: 'Create anomaly detection job',
+        defaultMessage: 'Detect anomaly',


Suggested change

defaultMessage: 'Detect anomaly',

defaultMessage: 'Detect anomalies',

Updated copy in 2ecb655 👍

…-fix'

…iu1/kibana into dashboard/actions-menu-reorg

x-pack/plugins/lens/public/app_plugin/lens_top_nav.tsx

…rd/actions-menu-reorg

davismcphee

Code-only review. Data Discovery functional test removal LGTM since it looks like the functionality it was testing has been removed 👍

…rd/actions-menu-reorg

jgowdyelastic

ML changes LGTM

cnasikas

Cases changes LGTM!

Heenawter

Tested locally + code review - LGTM, minus a few lines that should be removed 👍 Great job on this!

src/plugins/dashboard/public/dashboard_app/_dashboard_app_strings.ts

..._enhanced/public/services/drilldowns/actions/flyout_edit_drilldown/flyout_edit_drilldown.tsx

...anced/public/services/drilldowns/actions/flyout_create_drilldown/flyout_create_drilldown.tsx

…iu1/kibana into dashboard/actions-menu-reorg

andreadelrio

Design changes LGTM. Thanks!

kibana-ci · 2024-04-03T21:27:10Z

💚 Build Succeeded

Buildkite Build
Commit: 151f463

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`cases`	715	714	-1
`dashboard`	440	437	-3
total			-4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dashboard`	389.7KB	392.9KB	+3.2KB
`lens`	1.4MB	1.4MB	-5.0B
`ml`	3.7MB	3.7MB	-12.0B
total			+3.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cases`	149.1KB	147.7KB	-1.3KB
`dashboard`	37.0KB	36.9KB	-148.0B
`dashboardEnhanced`	15.4KB	15.3KB	-118.0B
`lens`	46.3KB	46.3KB	-6.0B
`presentationPanel`	42.5KB	41.9KB	-573.0B
`uiActions`	20.3KB	20.3KB	+24.0B
total			-2.1KB

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`cases`	21	19	-2
`dashboard`	42	40	-2
total			-4

History

💚 Build #200936 succeeded 86cdf73
💔 Build #200666 failed 92c887b
💔 Build #200586 failed 081d4e0
💛 Build #200398 was flaky 063026c
💔 Build #200360 failed 856a7fd
💔 Build #200348 failed 40527fc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nickofthyme

Vis changes LGTM 🎉

Contributes to: elastic#194817 Why I assigned them: Assigned advanced_settings due to elastic#175255 Assigned dashboard_controls due to elastic#190797 Assigned dashboard_links due to elastic#174772 Assigned dashboard_panel_options due to elastic#178596 Assigned grok_debugger due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned helpers due to elastic#164341 (call site) Assigned home due to elastic#103192 Assigned index_lifecycle_management due to elastic#116207 Assigned ingest_node_pipelines due to elastic#113783 Assigned kibana_overview due to https://github.com/elastic/kibana/blob/f00ac7a8a21463e6bb4a2784c3a3884f36c62900/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned management due to elastic#165705 Assigned painless_lab due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/painless_lab/kibana.jsonc#L4 Assigned search_profiler due to elastic#195343 Assigned uptime due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/uptime/kibana.jsonc#L4 Assigned lens due to elastic#175893 Assigned ml_anomaly_detection due to elastic#162126 Assigned canvas due to elastic#164376 Assigned cc replication due to elastic#149069 Assigned enterpise search due to elastic#79359 Assigned graph to due elastic#190797 Assigned license_management due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/license_management/kibana.jsonc#L4 Assigned maps due to elastic#155161 Assigned observability due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability/kibana.jsonc#L4 Assigned remote clusters due to elastic#96989 Assigned reporting due to elastic#121435 Assigned rollup_jobs due to https://github.com/elastic/kibana/blob/d57bc9a5d7d64f86b550eff7997605a3090aee9a/x-pack/plugins/rollup/kibana.jsonc#L4 Assigned watcher due to elastic#119717

cqliu1 added 3 commits March 12, 2024 20:09

Remove replace panel action

6ac40bf

Add grouping to delete panel action

e30ef4d

Update context menu order

b3dec86

cqliu1 marked this pull request as ready for review March 21, 2024 20:56

cqliu1 requested review from a team as code owners March 21, 2024 20:56

Merge branch 'main' into dashboard/actions-menu-reorg

5d6c1bb

cqliu1 added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Mar 21, 2024

cqliu1 added release_note:enhancement loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. v8.14.0 labels Mar 21, 2024

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

1857d4f

…fix'

botelastic bot added the Feature:Drilldowns Embeddable panel Drilldowns label Mar 21, 2024

jgowdyelastic reviewed Mar 22, 2024

View reviewed changes

Dosant approved these changes Mar 22, 2024

View reviewed changes

Update actions copy

2ecb655

cqliu1 requested a review from a team as a code owner March 22, 2024 23:00

kibanamachine and others added 3 commits March 22, 2024 23:40

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

ac46316

…-fix'

Fix typos

38ef88e

Merge branch 'dashboard/actions-menu-reorg' of https://github.com/cql…

acd5616

…iu1/kibana into dashboard/actions-menu-reorg

drewdaemon reviewed Mar 25, 2024

View reviewed changes

x-pack/plugins/lens/public/app_plugin/lens_top_nav.tsx Show resolved Hide resolved

Heenawter self-requested a review March 25, 2024 18:27

cqliu1 requested a review from a team as a code owner March 28, 2024 22:08

cqliu1 added 2 commits March 28, 2024 15:09

Fix image embeddable test

ba5f5d4

Merge branch 'main' of https://github.com/elastic/kibana into dashboa…

77a6b94

…rd/actions-menu-reorg

davismcphee approved these changes Mar 30, 2024

View reviewed changes

cqliu1 added 3 commits April 1, 2024 09:50

Merge branch 'main' of https://github.com/elastic/kibana into dashboa…

40527fc

…rd/actions-menu-reorg

Fix remaining tests

856a7fd

Remove unused services

063026c

jgowdyelastic approved these changes Apr 2, 2024

View reviewed changes

Merge branch 'main' into dashboard/actions-menu-reorg

081d4e0

cnasikas approved these changes Apr 2, 2024

View reviewed changes

Heenawter approved these changes Apr 2, 2024

View reviewed changes

cqliu1 added 5 commits April 2, 2024 11:32

Clean up

9f6b195

Merge branch 'dashboard/actions-menu-reorg' of https://github.com/cql…

d88bac0

…iu1/kibana into dashboard/actions-menu-reorg

Fix panel action sorting

92c887b

Merge branch 'main' into dashboard/actions-menu-reorg

696852f

Remove panel hover shadow in edit mode

86cdf73

cqliu1 requested a review from a team as a code owner April 3, 2024 18:10

andreadelrio approved these changes Apr 3, 2024

View reviewed changes

Merge branch 'main' into dashboard/actions-menu-reorg

151f463

cqliu1 requested review from a team and drewdaemon and removed request for drewdaemon April 3, 2024 20:21

nickofthyme approved these changes Apr 4, 2024

View reviewed changes

cqliu1 merged commit dd2155d into elastic:main Apr 4, 2024
18 checks passed

kibanamachine added the backport:skip This commit does not require backporting label Apr 4, 2024

cqliu1 deleted the dashboard/actions-menu-reorg branch April 4, 2024 14:56

thomheymann mentioned this pull request Apr 8, 2024

[Observability Onboarding] Removes hover effect from use case selection #180303

Merged

wayneseymour mentioned this pull request Oct 11, 2024

[FTR][Ownership] Assign ally/grps 1,2 & 3 #195964

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dashboard] Reorganize panel actions #178596

[Dashboard] Reorganize panel actions #178596

cqliu1 commented Mar 13, 2024 •

edited

Loading

amyjtechwriter commented Mar 20, 2024 •

edited by cqliu1

Loading

cqliu1 commented Mar 21, 2024

teresaalvarezsoler commented Mar 21, 2024

elasticmachine commented Mar 21, 2024

jgowdyelastic Mar 22, 2024

cqliu1 Mar 22, 2024

davismcphee left a comment

jgowdyelastic left a comment

cnasikas left a comment •

edited

Loading

Heenawter left a comment

andreadelrio left a comment

kibana-ci commented Apr 3, 2024

References to deprecated APIs

nickofthyme left a comment

	defaultMessage: 'Detect anomaly',
	defaultMessage: 'Detect anomalies',

[Dashboard] Reorganize panel actions #178596

[Dashboard] Reorganize panel actions #178596

Conversation

cqliu1 commented Mar 13, 2024 • edited Loading

Summary

Top level

More

Changes:

Checklist

Risk Matrix

For maintainers

amyjtechwriter commented Mar 20, 2024 • edited by cqliu1 Loading

cqliu1 commented Mar 21, 2024

teresaalvarezsoler commented Mar 21, 2024

elasticmachine commented Mar 21, 2024

jgowdyelastic Mar 22, 2024

Choose a reason for hiding this comment

cqliu1 Mar 22, 2024

Choose a reason for hiding this comment

davismcphee left a comment

Choose a reason for hiding this comment

jgowdyelastic left a comment

Choose a reason for hiding this comment

cnasikas left a comment • edited Loading

Choose a reason for hiding this comment

Heenawter left a comment

Choose a reason for hiding this comment

andreadelrio left a comment

Choose a reason for hiding this comment

kibana-ci commented Apr 3, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

References to deprecated APIs

History

nickofthyme left a comment

Choose a reason for hiding this comment

cqliu1 commented Mar 13, 2024 •

edited

Loading

amyjtechwriter commented Mar 20, 2024 •

edited by cqliu1

Loading

cnasikas left a comment •

edited

Loading