chore: merge release/v1.20.0 into master #10308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add v1.20.0-rc1 changelog Co-authored-by: Aayush Rajasekaran <arajasek94@gmail.com>
This reverts commit a9c1caa.
fix: shed: default to LOTUS_PATH for repo
feat: EthAPI: Add EthAddressToFilecoinAddress
* fix: eth: correctly decode EthGetStorageAt output We cbor-encode it. Also: 1. Actually use the passed block param. 2. Check if the target actor is an EVM actor to avoid nonsense outputs. fixes filecoin-project/ref-fvm#1621
We don't really want to do this in the FVM because it's Ethereum specific, but this makes sense to do in the Ethereum API. See: See https://docs.soliditylang.org/en/latest/control-structures.html#panic-via-assert-and-error-via-require
Includes changes from: - ipfs/go-block-format#37 - ipfs/boxo#58 (cherry picked from commit f572852)
This was migrated in ipfs/boxo#63. (cherry picked from commit d060df2)
Unfortunately, we need to execute the message twice to get this (unless we want to change some APIs). But it's unlikely to be a performance issue and will definitely help people debug failures.
EVM contracts track this number internally. fixes #10255
…errides fix: pack: support network name overrides in bundle git tags
…or-release chore: deps: bump go-libipfs to v0.4.1
fix: eth: return the correct nonce from EthGetTransactionCount
…CFix2 fix: test: change Filter rpc type from uint to hash to match fevm implementation
chore: ux: avoid actor not found
1. Return an error on gas estimation failure instead of logging. 2. Return early when processing signed messages on failure instead of continuing.
fix: eth: cleanup error cases
magik6k
approved these changes
Feb 20, 2023
| @@ -41,6 +41,10 @@ func (s *state10) Nonce() (uint64, error) { | |||
| return s.State.Nonce, nil | |||
| } | |||
|
|
|||
| func (s *state10) IsAlive() (bool, error) { | |||
| return s.State.Tombstone == nil, nil | |||
There was a problem hiding this comment.
Do we want other getters to behave differently if the tombstone is set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
End of week merge to get the latest 1.20.0 code into master.
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps