Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions on macOS #1271

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Fix GitHub Actions on macOS #1271

merged 4 commits into from
Apr 12, 2023

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Apr 11, 2023

🦟 Bug fix

Summary

Github Actions is failing for macOS on PRs #1268 and #1270 with the following error

==> Pouring python@3.11--3.11.3.monterey.bottle.tar.gz
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3-3.11
Target /usr/local/bin/2to3-3.11
already exists. You may want to remove it:
  rm '/usr/local/bin/2to3-3.11'

To force the link and overwrite all conflicting files:
  brew link --overwrite python@3.11

To list all files that would be deleted:
  brew link --overwrite --dry-run python@3.11

Since we seem to keep running into this, I'm trying the brew install --overwrite approach to see if it's a more permanent fix for this issue. That didn't work, so removing all 2to3-*.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from scpeters as a code owner April 11, 2023 15:08
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Apr 11, 2023
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from marcoag April 11, 2023 15:34
@azeey azeey self-assigned this Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #1271 (6f48a8f) into sdf9 (133bc87) will not change coverage.
The diff coverage is n/a.

❗ Current head 6f48a8f differs from pull request most recent head b47412b. Consider uploading reports for the commit b47412b to get more accurate results

@@           Coverage Diff           @@
##             sdf9    #1271   +/-   ##
=======================================
  Coverage   88.35%   88.35%           
=======================================
  Files          63       63           
  Lines       10092    10092           
=======================================
  Hits         8917     8917           
  Misses       1175     1175           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@traversaro
Copy link
Contributor

Just a cross-reference, the upstream issue for this problem is actions/setup-python#577 .

@azeey azeey merged commit 88de84f into sdf9 Apr 12, 2023
@azeey azeey deleted the azeey/fix_macos_action branch April 12, 2023 22:44
mjcarroll pushed a commit that referenced this pull request Jul 17, 2023
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
mjcarroll added a commit that referenced this pull request Aug 1, 2023
* Python script to replace ruby xmlschema generator

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Address reviewer feedback

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>

* Fix GitHub Actions on macOS (#1271)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

---------

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants