Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dataPtr private in Plugin class #1268

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

marcoag
Copy link
Member

@marcoag marcoag commented Apr 10, 2023

🦟 Bug fix

Summary

The dataPtr attribute on the Plugin Class is currently public. This PR makes it private. This is a quick fix as eventually classes should use GZ_UTILS_IMPL_PTR.

I also opened an issue here for future reference on the need of porting all remaining dataPtrs to use GZ_UTILS_IMPL_PTR.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #1268 (57678ee) into main (e98fcd8) will not change coverage.
The diff coverage is n/a.

❗ Current head 57678ee differs from pull request most recent head dd546a8. Consider uploading reports for the commit dd546a8 to get more accurate results

@@           Coverage Diff           @@
##             main    #1268   +/-   ##
=======================================
  Coverage   87.21%   87.21%           
=======================================
  Files         126      126           
  Lines       16304    16304           
=======================================
  Hits        14219    14219           
  Misses       2085     2085           
Impacted Files Coverage Δ
include/sdf/Plugin.hh 93.75% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@azeey azeey mentioned this pull request Apr 11, 2023
8 tasks
@azeey azeey merged commit 446d691 into main Apr 11, 2023
@azeey azeey deleted the marcoag/plugin_public_dataptr_fix branch April 11, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants