Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Update column_reflection_fallback to also use schema name for Trino #6350

Merged
merged 3 commits into from
Nov 15, 2022
Merged

[MAINTENANCE] Update column_reflection_fallback to also use schema name for Trino #6350

merged 3 commits into from
Nov 15, 2022

Conversation

kenwade4
Copy link
Contributor

Changes proposed in this pull request:

  • Update column_reflection_fallback to also use schema name for Trino

@netlify
Copy link

netlify bot commented Nov 14, 2022 •
edited
Loading

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit e45df4c
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6373bbabde162f00090713ff
😎 Deploy Preview https://deploy-preview-6350--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the devrel This item is being addressed by the Developer Relations Team label Nov 14, 2022
@ghost
Copy link

ghost commented Nov 14, 2022 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

anthonyburdi
anthonyburdi approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenwade4 kenwade4 enabled auto-merge (squash) November 15, 2022 16:17
@kenwade4 kenwade4 mentioned this pull request Nov 15, 2022
Closed
@kenwade4 kenwade4 merged commit f320054 into develop Nov 15, 2022
@kenwade4 kenwade4 deleted the misc/schema-in-trino-reflection-fallback branch November 15, 2022 17:00
Shinnnyshinshin pushed a commit that referenced this pull request Nov 15, 2022
Merge branch 'develop' into f/dx-67/sql-pk-feature
79b2dea 
* develop:
  [MAINTENANCE] Update column_reflection_fallback to also use schema name for Trino (#6350)
  [MAINTENANCE] Misc cleanup of GX Cloud helpers (#6352)
  [MAINTENANCE] Pin `mypy` to `0.990` (#6361)
  Subject: Support to include ID/PK in validation result for each row t… (#5876)
  [MAINTENANCE] Fix computed metrics type hint in ExecutionEngine.resolve_metrics() method (#6347)
  [MAINTENANCE] Refactor `usage_stats_opt_out` method in DataContext (#5339)
  Zep PostgresDatasource returns a list of batches. (#6341)
  [DOCS] Add `yarn snippet-check` command (#6351)
  [MAINTENANCE] Refactor out `termcolor` dependency (#6348)
  [MAINTENANCE] Move Cloud-specific enums to `cloud_constants.py` (#6349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyburdi anthonyburdi anthonyburdi approved these changes

Assignees
No one assigned
Labels
devrel This item is being addressed by the Developer Relations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenwade4 @anthonyburdi