[MAINTENANCE] Pin mypy to 0.990
#6361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👇 Click on the image for a new way to code review
Legend |
Kilo59
commented
Nov 15, 2022
| @@ -752,7 +752,6 @@ def show_expectations_by_expectation_type( | |||
| pprint.pprint( | |||
| object=pprint_objects, | |||
| indent=2, | |||
| sort_dicts=False, | |||
There was a problem hiding this comment.
@NathanFarmer
This wasn't added until python 3.8 😢
https://docs.python.org/3/library/pprint.html#pprint.PrettyPrinter
cdkini
approved these changes
Nov 15, 2022
Kilo59
commented
Nov 15, 2022
| @@ -13,6 +13,7 @@ skip_gitignore = true | |||
| extend_skip_glob = ['venv/*', 'docs/*'] | |||
|
|
|||
| [tool.mypy] | |||
| python_version = "3.7" | |||
There was a problem hiding this comment.
This should help a bit with getting consistent errors across dev environments.
If you are using a python 3.10 feature that doesn't exist in 3.7 mypy should warn you.
6 tasks
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Nov 15, 2022
* develop: [MAINTENANCE] Update column_reflection_fallback to also use schema name for Trino (#6350) [MAINTENANCE] Misc cleanup of GX Cloud helpers (#6352) [MAINTENANCE] Pin `mypy` to `0.990` (#6361) Subject: Support to include ID/PK in validation result for each row t… (#5876) [MAINTENANCE] Fix computed metrics type hint in ExecutionEngine.resolve_metrics() method (#6347) [MAINTENANCE] Refactor `usage_stats_opt_out` method in DataContext (#5339) Zep PostgresDatasource returns a list of batches. (#6341) [DOCS] Add `yarn snippet-check` command (#6351) [MAINTENANCE] Refactor out `termcolor` dependency (#6348) [MAINTENANCE] Move Cloud-specific enums to `cloud_constants.py` (#6349)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
The following changes should make our typing CI step much more consistent and reliable.
Pin mypy version to prevent CI breakage - as recommended by
mypyUpdate
mypyconfig to always run as if it was python 3.7 (our oldest supported version)pprintrelated bug - https://docs.python.org/3/library/pprint.html#pprint.PrettyPrinter