Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add yarn snippet-check command #6351

Merged
merged 4 commits into from
Nov 14, 2022
Merged

[DOCS] Add yarn snippet-check command #6351

merged 4 commits into from
Nov 14, 2022

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Nov 14, 2022 •
edited
Loading

Changes proposed in this pull request:

  • Make the snippet.js file in our custom Remark plugin invokable to aid with development.
  • yarn snippet-check <FILE_ARGS> will show which snippets are contained within the input files.

Loom: https://www.loom.com/share/6ca4bf2452124dd38f71f4ef07d3ad7a

Definition of Done

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@netlify
Copy link

netlify bot commented Nov 14, 2022 •
edited
Loading

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 224e4c2
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63729135ec0360000907db45
😎 Deploy Preview https://deploy-preview-6351--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Nov 14, 2022 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@cdkini cdkini self-assigned this Nov 14, 2022
@cdkini cdkini requested review from Rachel-Reverie and a team November 14, 2022 19:00
Rachel-Reverie
Rachel-Reverie approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@Rachel-Reverie Rachel-Reverie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdkini cdkini merged commit 8b358d2 into develop Nov 14, 2022
@cdkini cdkini deleted the d/_/add_snippet-check_cmd branch November 14, 2022 19:44
Shinnnyshinshin pushed a commit that referenced this pull request Nov 15, 2022
Merge branch 'develop' into f/dx-67/sql-pk-feature
79b2dea 
* develop:
  [MAINTENANCE] Update column_reflection_fallback to also use schema name for Trino (#6350)
  [MAINTENANCE] Misc cleanup of GX Cloud helpers (#6352)
  [MAINTENANCE] Pin `mypy` to `0.990` (#6361)
  Subject: Support to include ID/PK in validation result for each row t… (#5876)
  [MAINTENANCE] Fix computed metrics type hint in ExecutionEngine.resolve_metrics() method (#6347)
  [MAINTENANCE] Refactor `usage_stats_opt_out` method in DataContext (#5339)
  Zep PostgresDatasource returns a list of batches. (#6341)
  [DOCS] Add `yarn snippet-check` command (#6351)
  [MAINTENANCE] Refactor out `termcolor` dependency (#6348)
  [MAINTENANCE] Move Cloud-specific enums to `cloud_constants.py` (#6349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rachel-Reverie Rachel-Reverie Rachel-Reverie approved these changes

Assignees

@cdkini cdkini

Labels
core-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdkini @Rachel-Reverie