Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Back out protobuf-changes to dynamic address book for release 0.51 #358

Merged
merged 5 commits into from
May 29, 2024
Merged

feat: Back out protobuf-changes to dynamic address book for release 0.51 #358

merged 5 commits into from
May 29, 2024

Conversation

iwsimon
Copy link
Contributor

@iwsimon iwsimon commented May 28, 2024 •
edited
Loading

Description:

Related issue(s):

Fixes #357

@iwsimon
Revert "feat: added NodeGetInfoResponse to response.proto (#355)"
c0b4301 
This reverts commit 43d9159.
@iwsimon
Revert "Added NodeGetInfo (#347)"
9de77c3 
This reverts commit 17fb148.
@iwsimon
Revert "feat: Dynamic Address Book Phase 2 protobufs changes (#344)"
c7861b0 
This reverts commit e650477 as hedera-servives #13265 asked.

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
@iwsimon iwsimon requested review from a team as code owners May 28, 2024 19:44
@iwsimon iwsimon self-assigned this May 28, 2024
jsync-swirlds
jsync-swirlds reviewed May 28, 2024
View reviewed changes
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one item that probably shouldn't change.

services/response_code.proto Outdated Show resolved Hide resolved
@iwsimon
Align the code.
db7694a 
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
kimbor
kimbor previously approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@kimbor kimbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@iwsimon
Changed INVALID_MAX_AUTO_ASSOCIATIONS back to 346 by review request.
8ceb653 
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
@iwsimon iwsimon changed the title feat: Back out protobuf-changes related to dynamic address book for release 0.51 feat: Back out protobuf-changes to dynamic address book for release 0.51 May 29, 2024
@iwsimon iwsimon merged commit 6096d43 into main May 29, 2024
1 check passed
@iwsimon iwsimon deleted the 13265-backout-dab-change branch May 29, 2024 19:01
@iwsimon iwsimon restored the 13265-backout-dab-change branch May 29, 2024 19:01
@iwsimon iwsimon deleted the 13265-backout-dab-change branch May 29, 2024 20:37
iwsimon added a commit that referenced this pull request Jun 3, 2024
@iwsimon
Revert "feat: Back out protobuf-changes to dynamic address book for r…
2f7f298 
…elease 0.51 (#358)"

This reverts commit 6096d43

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
iwsimon added a commit that referenced this pull request Jun 3, 2024
@iwsimon
feat: Add back Dynamic Address Book Phase 2 protobufs change (#361)
0da01d5 
* added deleted in node.proto

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>

* Added MAX_NODE_HAVE_BEEN_CREATED

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>

* updated comments with latest FQDN meeting.

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>

* added more response code

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>

* added more response code

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>

* Revert "feat: Back out protobuf-changes to dynamic address book for release 0.51 (#358)"

This reverts commit 6096d43

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>

---------

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
netopyr added a commit that referenced this pull request Jul 18, 2024
@netopyr
Merge branch 'main' into tmp-hip796-protos-test
146d477 
* main: (21 commits)
  feat: 13135 Added PlatformState protobuf representation (#349)
  feat: Change AddressBookService package to proto (#386)
  feat: add admin_key to node_create.proto, node_update.proto and node.proto (#380)
  HIP 904 proto updates for token reject (#367)
  chore: Updated codeowners to include devops-ci (#384)
  feat: remove node_get_info.proto (#378)
  fixed INVALID_GOSSIP_CA_CERTIFICATE (#375)
  fix: Fixing single-letter mismatch to expectations (#373)
  feat: Update specification text for address book service (#346)
  feat: Add more response codes for Dynamic Address Book Phase 2 (#370)
  feat: maxAutoAssociations updates for contract transactions (#359)
  Added more response codes for Dynamic Address Book Phase 2 (#364)
  feat: Add back Dynamic Address Book Phase 2 protobufs change (#361)
  feat: Back out protobuf-changes to dynamic address book for release 0.51 (#358)
  feat: added NodeGetInfoResponse to response.proto (#355)
  feat: HIP-904 maxAutoAssociations updates (#348)
  chore: added consensus data protobuf (#350)
  Added NodeGetInfo (#347)
  feat: Dynamic Address Book Phase 2 protobufs changes (#344)
  feat: define event protobufs (#338)
  ...

# Conflicts:
#	services/basic_types.proto
#	services/schedulable_transaction_body.proto
#	services/token_service.proto
#	services/transaction_body.proto
#	services/transaction_receipt.proto
netopyr added a commit that referenced this pull request Jul 18, 2024
@netopyr
Merge branch 'main' into tmp-hip796-protos
1e2cea0 
* main: (21 commits)
  feat: 13135 Added PlatformState protobuf representation (#349)
  feat: Change AddressBookService package to proto (#386)
  feat: add admin_key to node_create.proto, node_update.proto and node.proto (#380)
  HIP 904 proto updates for token reject (#367)
  chore: Updated codeowners to include devops-ci (#384)
  feat: remove node_get_info.proto (#378)
  fixed INVALID_GOSSIP_CA_CERTIFICATE (#375)
  fix: Fixing single-letter mismatch to expectations (#373)
  feat: Update specification text for address book service (#346)
  feat: Add more response codes for Dynamic Address Book Phase 2 (#370)
  feat: maxAutoAssociations updates for contract transactions (#359)
  Added more response codes for Dynamic Address Book Phase 2 (#364)
  feat: Add back Dynamic Address Book Phase 2 protobufs change (#361)
  feat: Back out protobuf-changes to dynamic address book for release 0.51 (#358)
  feat: added NodeGetInfoResponse to response.proto (#355)
  feat: HIP-904 maxAutoAssociations updates (#348)
  chore: added consensus data protobuf (#350)
  Added NodeGetInfo (#347)
  feat: Dynamic Address Book Phase 2 protobufs changes (#344)
  feat: define event protobufs (#338)
  ...
vtronkov pushed a commit that referenced this pull request Jul 23, 2024
@iwsimon @vtronkov
feat: Back out protobuf-changes to dynamic address book for release 0…
8c3623c 
….51 (#358)

* Revert "feat: added NodeGetInfoResponse to response.proto (#355)"

This reverts commit 43d9159.

* Revert "Added NodeGetInfo (#347)"

This reverts commit 17fb148.

* Revert "feat: Dynamic Address Book Phase 2 protobufs changes (#344)"

This reverts commit e650477 as hedera-servives #13265 asked.

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>

* Align the code.

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>

* Changed INVALID_MAX_AUTO_ASSOCIATIONS back to 346 by review request.

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>

---------

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
vtronkov pushed a commit that referenced this pull request Jul 23, 2024
@iwsimon @vtronkov
feat: Add back Dynamic Address Book Phase 2 protobufs change (#361)
edb156c 
* added deleted in node.proto

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>

* Added MAX_NODE_HAVE_BEEN_CREATED

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>

* updated comments with latest FQDN meeting.

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>

* added more response code

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>

* added more response code

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>

* Revert "feat: Back out protobuf-changes to dynamic address book for release 0.51 (#358)"

This reverts commit 6096d43

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>

---------

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimbor kimbor kimbor approved these changes

@povolev15 povolev15 povolev15 approved these changes

@Neeharika-Sompalli Neeharika-Sompalli Neeharika-Sompalli approved these changes

@jsync-swirlds jsync-swirlds jsync-swirlds approved these changes

@edwin-greene edwin-greene Awaiting requested review from edwin-greene edwin-greene is a code owner automatically assigned from hashgraph/mirror-node

Assignees

@iwsimon iwsimon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Back out protobuf-changes to dynamic address book for release 0.51
5 participants
@iwsimon @kimbor @povolev15 @Neeharika-Sompalli @jsync-swirlds