feat: Add more response codes for Dynamic Address Book Phase 2 #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
povolev15
previously approved these changes
Jun 7, 2024
|
You may want to coordinate with the HIP 904 PR, you're both editing the same response file, and one of you will need to handle conflicts. I updated the numbers. Thanks for letting me know. |
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
povolev15
approved these changes
Jun 7, 2024
jsync-swirlds
approved these changes
Jun 7, 2024
This was referenced Jun 14, 2024
netopyr
added a commit
that referenced
this pull request
Jul 18, 2024
* main: (21 commits) feat: 13135 Added PlatformState protobuf representation (#349) feat: Change AddressBookService package to proto (#386) feat: add admin_key to node_create.proto, node_update.proto and node.proto (#380) HIP 904 proto updates for token reject (#367) chore: Updated codeowners to include devops-ci (#384) feat: remove node_get_info.proto (#378) fixed INVALID_GOSSIP_CA_CERTIFICATE (#375) fix: Fixing single-letter mismatch to expectations (#373) feat: Update specification text for address book service (#346) feat: Add more response codes for Dynamic Address Book Phase 2 (#370) feat: maxAutoAssociations updates for contract transactions (#359) Added more response codes for Dynamic Address Book Phase 2 (#364) feat: Add back Dynamic Address Book Phase 2 protobufs change (#361) feat: Back out protobuf-changes to dynamic address book for release 0.51 (#358) feat: added NodeGetInfoResponse to response.proto (#355) feat: HIP-904 maxAutoAssociations updates (#348) chore: added consensus data protobuf (#350) Added NodeGetInfo (#347) feat: Dynamic Address Book Phase 2 protobufs changes (#344) feat: define event protobufs (#338) ... # Conflicts: # services/basic_types.proto # services/schedulable_transaction_body.proto # services/token_service.proto # services/transaction_body.proto # services/transaction_receipt.proto
netopyr
added a commit
that referenced
this pull request
Jul 18, 2024
* main: (21 commits) feat: 13135 Added PlatformState protobuf representation (#349) feat: Change AddressBookService package to proto (#386) feat: add admin_key to node_create.proto, node_update.proto and node.proto (#380) HIP 904 proto updates for token reject (#367) chore: Updated codeowners to include devops-ci (#384) feat: remove node_get_info.proto (#378) fixed INVALID_GOSSIP_CA_CERTIFICATE (#375) fix: Fixing single-letter mismatch to expectations (#373) feat: Update specification text for address book service (#346) feat: Add more response codes for Dynamic Address Book Phase 2 (#370) feat: maxAutoAssociations updates for contract transactions (#359) Added more response codes for Dynamic Address Book Phase 2 (#364) feat: Add back Dynamic Address Book Phase 2 protobufs change (#361) feat: Back out protobuf-changes to dynamic address book for release 0.51 (#358) feat: added NodeGetInfoResponse to response.proto (#355) feat: HIP-904 maxAutoAssociations updates (#348) chore: added consensus data protobuf (#350) Added NodeGetInfo (#347) feat: Dynamic Address Book Phase 2 protobufs changes (#344) feat: define event protobufs (#338) ...
vtronkov
pushed a commit
that referenced
this pull request
Jul 23, 2024
* add more response code Signed-off-by: Iris Simon <iris.simon@swirldslabs.com> * updated to avoid conflict with HIP 904 changes. Signed-off-by: Iris Simon <iris.simon@swirldslabs.com> --------- Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #369
Notes for reviewer:
Checklist