Make upper bound of ChainReaderBlockStreamer inclusive
#1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 4 files ±0 52 suites ±0 9m 11s ⏱️ -1s Results for commit 2380c63. ± Comparison against base commit 4bc87f0. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
jpraynaud
approved these changes
Jul 16, 2024
sfauvel
approved these changes
Jul 16, 2024
Before its upper bound was exclusive this was fine when others subsystems were also exclusive but this changed with the fixes for #1785: now the `until` parameter the last block to include in the signature instead of being the block were we should stop polling.
From `1` to `15`. With only `1` the chain reader used to parse transactions from the chain would switch to 'agency' mode since we are really close to the tip of the chain. In this mode the client/server relationship is reversed and our code must wait a message from the cardano node in order to continue polling blocks. But the chain reader don't handle that case when we are setting the starting chain point, leading to a recuring error that would block all subsenquent calls. So increasing the security parameter allow us to avoid this problem by never be so close to the tip than we switch mode.
* Mithril-aggregator from `0.5.43` to `0.5.44` * Mithril-signer from `0.2.165` to `0.2.166` * Mithril-common from `0.4.30` to `0.4.31` * Mithril-end-to-end from `0.4.21` to `0.4.22`
Alenar
force-pushed
the
djo/1785/chain_block_streamer_inclusive_upper_bound
branch
from
82d00d4
to
2380c63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR changes how the
ChainReaderBlockStreamerhandle it's upper bound (itsuntilparameter):Before its upper bound was exclusive, this was fine when others subsystems were also exclusive but this changed with the fixes for #1785: now the
untilparameter is the last block to include in the signature instead of being the block where to stop polling.Pre-submit checklist
Comments
Should this parameter be still named
until?Issue(s)
Relates to #1785