Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make upper bound of ChainReaderBlockStreamer inclusive #1835

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Make upper bound of ChainReaderBlockStreamer inclusive #1835

merged 3 commits into from
Jul 16, 2024

Commits on Jul 16, 2024

  1. Make upper bound of ChainReaderBlockStreamer inclusive 

    Before its upper bound was exclusive this was fine when others
subsystems were also exclusive but this changed with the fixes
for #1785: now the `until` parameter the last block to include in the
signature instead of being the block were we should stop polling.
    @Alenar
    Alenar committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    5ea2904 View commit details
    Browse the repository at this point in the history

  2. Increase e2e aggregator security parameter for CardanoTransactions 

    From `1` to `15`.

With only `1` the chain reader used to parse transactions from the chain
would switch to 'agency' mode since we are really close to the tip of
the chain.
In this mode the client/server relationship is reversed and our code
must wait a message from the cardano node in order to continue polling
blocks.
But the chain reader don't handle that case when we are setting the
starting chain point, leading to a recuring error that would block all
subsenquent calls.

So increasing the security parameter allow us to avoid this problem by
never be so close to the tip than we switch mode.
    @Alenar
    Alenar committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    8cd4833 View commit details
    Browse the repository at this point in the history

  3. Upgrade crates versions 

    * Mithril-aggregator from `0.5.43` to `0.5.44`
* Mithril-signer from `0.2.165` to `0.2.166`
* Mithril-common from `0.4.30` to `0.4.31`
* Mithril-end-to-end from `0.4.21` to `0.4.22`
    @Alenar
    Alenar committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2380c63 View commit details
    Browse the repository at this point in the history