Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tox environments #1967

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Update tox environments #1967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
456c376
Update tox environments
atugushev Aug 18, 2023
e9e39bd
Add coverage factor to pypy job
atugushev Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ jobs:
pip-version:
- latest
env:
TOXENV: pip${{ matrix.pip-version }}
Copy link
Member Author

@atugushev atugushev Aug 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

874 passed, 1791 warnings in 997.59s (0:16:37)

Wow, 17 minutes on pypy with coverage vs 4 minutes.

@webknjaz, do you remember why the coverage wasn't set up in the first place in #1379? The speed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't have any pypy specific code, we can simply turn off the coverage there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess because of the slowness.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #1970.

TOXENV: pip${{ matrix.pip-version }}-coverage
steps:
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
Expand Down
1 change: 1 addition & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
envlist =
# NOTE: keep this in sync with the env list in .github/workflows/ci.yml.
py{37,38,39,310,311,312,py3}-pip{previous,latest,main}-coverage
pip{previous,latest,main}-coverage
checkqa
readme
skip_missing_interpreters = True
Expand Down