Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dbnode] Fix typo in log message #3298

Merged
merged 3 commits into from
Mar 2, 2021
Merged

[dbnode] Fix typo in log message #3298

merged 3 commits into from
Mar 2, 2021

Conversation

miroswan
Copy link
Contributor

What this PR does / why we need it:

Fixes typo in log message

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@miroswan
Update server.go
5e65abb 
Fix typo in log message
@CLAassistant
Copy link

CLAassistant commented Feb 27, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 27, 2021 •
edited
Loading

Codecov Report

Merging #3298 (da44ea0) into master (a997c83) will increase coverage by 11.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3298      +/-   ##
==========================================
+ Coverage    61.1%    72.4%   +11.3%     
==========================================
  Files        1016     1099      +83     
  Lines       95059   101504    +6445     
==========================================
+ Hits        58148    73579   +15431     
+ Misses      32302    22849    -9453     
- Partials     4609     5076     +467
Flag Coverage Δ
aggregator 76.5% <0.0%> (+15.4%) ⬆️
cluster 84.9% <0.0%> (+13.8%) ⬆️
collector 84.3% <0.0%> (+10.9%) ⬆️
dbnode 78.8% <0.0%> (+15.2%) ⬆️
m3em 74.4% <0.0%> (+5.4%) ⬆️
m3ninx 73.5% <0.0%> (+3.5%) ⬆️
metrics 19.9% <0.0%> (?)
msg 74.2% <0.0%> (+0.8%) ⬆️
query 67.3% <0.0%> (+19.9%) ⬆️
x 80.5% <0.0%> (+7.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a997c83...0ec3410. Read the comment docs.

@miroswan
Copy link
Contributor Author

Looks like there is a data race on master:

2021-02-28T07:02:02.279611970Z ==================
2021-02-28T07:02:02.279671158Z WARNING: DATA RACE
2021-02-28T07:02:02.279676001Z Read at 0x00c0875d6ab0 by goroutine 59:
2021-02-28T07:02:02.279679841Z   runtime.mapaccess1_faststr()
2021-02-28T07:02:02.279683185Z       /usr/local/go/src/runtime/map_faststr.go:12 +0x0
2021-02-28T07:02:02.279686907Z   github.com/m3db/m3/src/dbnode/storage/bootstrap.(*TestDataAccumulator).checkoutSeriesWithLock.func1()
2021-02-28T07:02:02.279700411Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/util.go:249 +0x2d9
2021-02-28T07:02:02.279704205Z   runtime.call64()
2021-02-28T07:02:02.279707726Z       /usr/local/go/src/runtime/asm_amd64.s:540 +0x3a
2021-02-28T07:02:02.279711296Z   reflect.Value.Call()
2021-02-28T07:02:02.279714768Z       /usr/local/go/src/reflect/value.go:321 +0xd3
2021-02-28T07:02:02.279718346Z   github.com/golang/mock/gomock.(*Call).DoAndReturn.func1()
2021-02-28T07:02:02.279721977Z       /go/pkg/mod/github.com/golang/mock@v1.4.4/gomock/call.go:123 +0x4ef
2021-02-28T07:02:02.279725681Z   github.com/golang/mock/gomock.(*Controller).Call()
2021-02-28T07:02:02.279729233Z       /go/pkg/mod/github.com/golang/mock@v1.4.4/gomock/controller.go:221 +0x144
2021-02-28T07:02:02.279732948Z   github.com/m3db/m3/src/dbnode/storage/series.(*MockDatabaseSeries).LoadBlock()
2021-02-28T07:02:02.279736551Z       /go/src/github.com/m3db/m3/src/dbnode/storage/series/series_mock.go:213 +0x1a3
2021-02-28T07:02:02.279740359Z   github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs.(*fileSystemSource).readNextEntryAndRecordBlock()
2021-02-28T07:02:02.279744233Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs/source.go:704 +0x638
2021-02-28T07:02:02.279747933Z   github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs.(*fileSystemSource).loadShardReadersDataIntoShardResult()
2021-02-28T07:02:02.279751757Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs/source.go:432 +0xbb6
2021-02-28T07:02:02.279755432Z   github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs.(*fileSystemSource).bootstrapFromReaders()
2021-02-28T07:02:02.279759169Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs/source.go:324 +0x238
2021-02-28T07:02:02.279762868Z   github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs.(*fileSystemSource).read.func3()
2021-02-28T07:02:02.279766515Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs/source.go:868 +0x21e
2021-02-28T07:02:02.279770400Z 
2021-02-28T07:02:02.279773795Z Previous write at 0x00c0875d6ab0 by goroutine 57:
2021-02-28T07:02:02.279777309Z   runtime.mapassign_faststr()
2021-02-28T07:02:02.279780710Z       /usr/local/go/src/runtime/map_faststr.go:202 +0x0
2021-02-28T07:02:02.279784344Z   github.com/m3db/m3/src/dbnode/storage/bootstrap.(*TestDataAccumulator).checkoutSeriesWithLock.func1()
2021-02-28T07:02:02.280193807Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/util.go:249 +0x4de
2021-02-28T07:02:02.280201435Z   runtime.call64()
2021-02-28T07:02:02.280205190Z       /usr/local/go/src/runtime/asm_amd64.s:540 +0x3a
2021-02-28T07:02:02.280208798Z   reflect.Value.Call()
2021-02-28T07:02:02.280212086Z       /usr/local/go/src/reflect/value.go:321 +0xd3
2021-02-28T07:02:02.280215598Z   github.com/golang/mock/gomock.(*Call).DoAndReturn.func1()
2021-02-28T07:02:02.280224193Z       /go/pkg/mod/github.com/golang/mock@v1.4.4/gomock/call.go:123 +0x4ef
2021-02-28T07:02:02.280228154Z   github.com/golang/mock/gomock.(*Controller).Call()
2021-02-28T07:02:02.280231530Z       /go/pkg/mod/github.com/golang/mock@v1.4.4/gomock/controller.go:221 +0x144
2021-02-28T07:02:02.280235284Z   github.com/m3db/m3/src/dbnode/storage/series.(*MockDatabaseSeries).LoadBlock()
2021-02-28T07:02:02.280238934Z       /go/src/github.com/m3db/m3/src/dbnode/storage/series/series_mock.go:213 +0x1a3
2021-02-28T07:02:02.280242558Z   github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs.(*fileSystemSource).readNextEntryAndRecordBlock()
2021-02-28T07:02:02.280246274Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs/source.go:704 +0x638
2021-02-28T07:02:02.280250018Z   github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs.(*fileSystemSource).loadShardReadersDataIntoShardResult()
2021-02-28T07:02:02.280253778Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs/source.go:432 +0xbb6
2021-02-28T07:02:02.280257527Z   github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs.(*fileSystemSource).bootstrapFromReaders()
2021-02-28T07:02:02.280261108Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs/source.go:324 +0x238
2021-02-28T07:02:02.280264801Z   github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs.(*fileSystemSource).read.func3()
2021-02-28T07:02:02.280268490Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs/source.go:868 +0x21e
2021-02-28T07:02:02.280272146Z 
2021-02-28T07:02:02.280275391Z Goroutine 59 (running) created at:
2021-02-28T07:02:02.280278779Z   github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs.(*fileSystemSource).read()
2021-02-28T07:02:02.280282437Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs/source.go:867 +0x7b0
2021-02-28T07:02:02.280285840Z   github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs.(*fileSystemSource).Read()
2021-02-28T07:02:02.280289474Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs/source.go:165 +0x68f
2021-02-28T07:02:02.280293130Z   github.com/m3db/m3/src/dbnode/storage/bootstrap.(*NamespacesTester).TestReadWith()
2021-02-28T07:02:02.280567172Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/util.go:582 +0x1dc
2021-02-28T07:02:02.280574675Z   github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs.validateReadResults()
2021-02-28T07:02:02.280578474Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs/source_data_test.go:545 +0x27c
2021-02-28T07:02:02.280582420Z   github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs.TestReadNilTimeRanges()
2021-02-28T07:02:02.280586641Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs/source_data_test.go:588 +0x2c7
2021-02-28T07:02:02.280594717Z   testing.tRunner()
2021-02-28T07:02:02.280598278Z       /usr/local/go/src/testing/testing.go:909 +0x199
2021-02-28T07:02:02.280601839Z 
2021-02-28T07:02:02.280605052Z Goroutine 57 (finished) created at:
2021-02-28T07:02:02.280608632Z   github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs.(*fileSystemSource).read()
2021-02-28T07:02:02.280612409Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs/source.go:867 +0x7b0
2021-02-28T07:02:02.280616207Z   github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs.(*fileSystemSource).Read()
2021-02-28T07:02:02.280619849Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs/source.go:165 +0x68f
2021-02-28T07:02:02.280623644Z   github.com/m3db/m3/src/dbnode/storage/bootstrap.(*NamespacesTester).TestReadWith()
2021-02-28T07:02:02.280627385Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/util.go:582 +0x1dc
2021-02-28T07:02:02.280631088Z   github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs.validateReadResults()
2021-02-28T07:02:02.280634874Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs/source_data_test.go:545 +0x27c
2021-02-28T07:02:02.280638721Z   github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs.TestReadNilTimeRanges()
2021-02-28T07:02:02.280642396Z       /go/src/github.com/m3db/m3/src/dbnode/storage/bootstrap/bootstrapper/fs/source_data_test.go:588 +0x2c7
2021-02-28T07:02:02.280646226Z   testing.tRunner()
2021-02-28T07:02:02.280649624Z       /usr/local/go/src/testing/testing.go:909 +0x199
2021-02-28T07:02:02.280653193Z ==================

@miroswan miroswan mentioned this pull request Feb 28, 2021
Closed
@miroswan
Copy link
Contributor Author

miroswan commented Mar 2, 2021

Once #3300 is merged and this PR is updated I think we'll be in good shape.

@wesleyk wesleyk merged commit 6ee051b into m3db:master Mar 2, 2021
soundvibe added a commit that referenced this pull request Mar 3, 2021
@soundvibe
Merge branch 'master' into linasn/series-resolver
34e85db 
* master:
  [aggregator] Move placement checks to a background job (#3315)
  [tests] Remove a few more usages of NoOpAllBootstrapper from tests (#3314)
  [coordinator] make drop timestamp apply to the metric rather than specific rule (#3310)
  Update server.go (#3298)
  Fix Data Race in checkoutSeriesWithLock (#3300)
  [query] Allow configuration of placement options (#3304)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleyk wesleyk wesleyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miroswan @CLAassistant @wesleyk