[aggregator] Move placement checks to a background job #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdarulis
commented
Mar 3, 2021
Comment on lines
-353
to
-355
| if agg.electionManager.ElectionState() == FollowerState { | ||
| return writer.NewBlackholeWriter(), nil | ||
| } |
There was a problem hiding this comment.
should be fine to remove this 2nd check, as double-writing metrics in this rare case is not the end of the world.
Codecov Report
@@ Coverage Diff @@
## master #3315 +/- ##
=========================================
+ Coverage 72.3% 72.5% +0.1%
=========================================
Files 1099 1099
Lines 101732 101512 -220
=========================================
+ Hits 73584 73600 +16
+ Misses 23062 22833 -229
+ Partials 5086 5079 -7
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
jcerniauskas
approved these changes
Mar 3, 2021
soundvibe
added a commit
that referenced
this pull request
Mar 3, 2021
* master: [aggregator] Move placement checks to a background job (#3315) [tests] Remove a few more usages of NoOpAllBootstrapper from tests (#3314) [coordinator] make drop timestamp apply to the metric rather than specific rule (#3310) Update server.go (#3298) Fix Data Race in checkoutSeriesWithLock (#3300) [query] Allow configuration of placement options (#3304)
vpranckaitis
added a commit
that referenced
this pull request
Apr 23, 2021
This reverts commit b24eccc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change reduces lock contention by doing less work on the hot path. It also changes the error returned in some cases to shard not owned, not aggregator is not open - the difference is a semantic one, since it's just a guard against initialization bugs.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: