Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Allow configuration of placement options #3304

Merged
merged 6 commits into from
Mar 2, 2021

Conversation

notbdu
Copy link
Contributor

@notbdu notbdu commented Mar 1, 2021

What this PR does / why we need it:

Allows optional configuration of placement options inside of the m3query/coord config. Default behavior/options are retained as config options are optional.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@notbdu notbdu force-pushed the bdu/m3coord-configure-placement branch from 084aedc to 7a08c04 Compare March 1, 2021 21:30
Copy link
Collaborator

@schallert schallert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if we're confident the config type change won't break existing config files.

ClusterManagement *ClusterManagementConfiguration `yaml:"clusterManagement"`
// ClusterManagement for placement, namespaces and database management
// endpoints.
ClusterManagement ClusterManagementConfiguration `yaml:"clusterManagement"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this from a pointer to directly embedded? I can't think of any reasons off the top of my head, but am wondering if there's some way this could break deserializing existing configs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it since I wanted to use the default placement config inside of ClusterManagementConfiguration directly and didn't see any issues w/ the usage of this config w/in the code.

I don't think this will affect deserialization of existing configs? It's still optional in terms of the actual underlying yaml since I moved the pointer to be the actual Etcd config so prior behaviour is retained.

@notbdu notbdu force-pushed the bdu/m3coord-configure-placement branch from 8c2d6d0 to 6da810d Compare March 2, 2021 03:48
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #3304 (5742617) into master (5742617) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3304   +/-   ##
=======================================
  Coverage    72.3%    72.3%           
=======================================
  Files        1099     1099           
  Lines      101740   101740           
=======================================
  Hits        73616    73616           
  Misses      23041    23041           
  Partials     5083     5083           
Flag Coverage Δ
aggregator 76.4% <0.0%> (ø)
cluster 84.9% <0.0%> (ø)
collector 84.3% <0.0%> (ø)
dbnode 78.8% <0.0%> (ø)
m3em 74.4% <0.0%> (ø)
m3ninx 73.5% <0.0%> (ø)
metrics 19.9% <0.0%> (ø)
msg 74.2% <0.0%> (ø)
query 66.8% <0.0%> (ø)
x 80.7% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5742617...a9306db. Read the comment docs.

@notbdu notbdu merged commit 1a26bf5 into master Mar 2, 2021
@notbdu notbdu deleted the bdu/m3coord-configure-placement branch March 2, 2021 16:46
soundvibe added a commit that referenced this pull request Mar 3, 2021
* master:
  [aggregator] Move placement checks to a background job (#3315)
  [tests] Remove a few more usages of NoOpAllBootstrapper from tests (#3314)
  [coordinator] make drop timestamp apply to the metric rather than specific rule (#3310)
  Update server.go (#3298)
  Fix Data Race in checkoutSeriesWithLock (#3300)
  [query] Allow configuration of placement options (#3304)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants