-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Allow configuration of placement options #3304
Conversation
084aedc
to
7a08c04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if we're confident the config type change won't break existing config files.
ClusterManagement *ClusterManagementConfiguration `yaml:"clusterManagement"` | ||
// ClusterManagement for placement, namespaces and database management | ||
// endpoints. | ||
ClusterManagement ClusterManagementConfiguration `yaml:"clusterManagement"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this from a pointer to directly embedded? I can't think of any reasons off the top of my head, but am wondering if there's some way this could break deserializing existing configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it since I wanted to use the default placement config inside of ClusterManagementConfiguration
directly and didn't see any issues w/ the usage of this config w/in the code.
I don't think this will affect deserialization of existing configs? It's still optional in terms of the actual underlying yaml since I moved the pointer to be the actual Etcd config so prior behaviour is retained.
8c2d6d0
to
6da810d
Compare
Codecov Report
@@ Coverage Diff @@
## master #3304 +/- ##
=======================================
Coverage 72.3% 72.3%
=======================================
Files 1099 1099
Lines 101740 101740
=======================================
Hits 73616 73616
Misses 23041 23041
Partials 5083 5083
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
* master: [aggregator] Move placement checks to a background job (#3315) [tests] Remove a few more usages of NoOpAllBootstrapper from tests (#3314) [coordinator] make drop timestamp apply to the metric rather than specific rule (#3310) Update server.go (#3298) Fix Data Race in checkoutSeriesWithLock (#3300) [query] Allow configuration of placement options (#3304)
What this PR does / why we need it:
Allows optional configuration of placement options inside of the m3query/coord config. Default behavior/options are retained as config options are optional.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: