A functional AJAX Data Store Example now using HackerNews instead of Digg #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out the 400 errors were due to very large request sizes. I shudder at how much bigger mleibman's monitor is than mine. :) |
|
While I do have a 30" monitor, the grid size in the example is fixed, so that couldn't have been it. Some initial comments:
|
|
Solving the problem of Digg not working. Improved search term handling. Working around the limitations of ThriftDB API * maximum number of rows returned is 1000 * maximum individual query is 100 * ability to run multiple requests in parallel * only one indicator at a time Notes: * disabled sorting (API doesn't support it properly) - but this isn't a highlight of this specific example * adaptive spacing for individual rows would help
|
All issues except for parallel XHRs fixed. |
|
Loading indicator issue is still there. |
|
It only shows one indicator at a time. Is there another issue? |
…rag'n'dropping it into the recycle bin.
…oHeight is set. Let it expand to content.
…ever app SlickGrid is being used in.
…en options.autoHeight is on.
RandScullard
added a commit
to RandScullard/SlickGrid
that referenced
this pull request
Jun 21, 2013
… News search API rather than the now-obsolete Digg API. Some of the code that talks to HNSearch was taken from Aleks Jakulin's nice work on pull request mleibman#412 (commit d175aa1), but my changes to the example are more minimal. I've also improved the sorting a bit and added a sortable Date column.
RandScullard
added a commit
to RandScullard/SlickGrid
that referenced
this pull request
Jun 25, 2013
… News search API rather than the now-obsolete Digg API. Some of the code that talks to HNSearch was taken from Aleks Jakulin's nice work on pull request mleibman#412 (commit d175aa1), but my changes to the example are more minimal. I've also improved the sorting a bit and added a sortable Date column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving the problem of Digg not working by using HackerNews API provided by ThriftDB.
Notes:
* disabled sorting (API doesn't support it properly) - but this isn't a highlight of this specific example
* implemented running multiple requests in parallel, as well as multiple indicators
* Working around the limitations of ThriftDB API
* maximum number of rows returned is 1000
* maximum individual query is 100
* ability to run multiple requests in parallel
* known problem: if a request fails, the "buffering" indicator won't go away
* adaptive spacing for individual rows would help