Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed pyright issues #198

Merged
merged 12 commits into from
Jan 3, 2022
Merged

Fixed pyright issues #198

merged 12 commits into from
Jan 3, 2022

Conversation

ravi-mosaicml
Copy link
Contributor

@ravi-mosaicml ravi-mosaicml commented Jan 3, 2022 •
edited
Loading

  1. Updated pyright version to 1.1.203
  2. Update python for github tests to 3.9
  3. Made the pyproject.toml slightly stricter. Added warnings for untyped function signatures and implicit string concat, which should later be converted to errors.
  4. Removed unused variables and made those errors.
  5. Set all instance variables on __init__
  6. Fixed implicit None in signatures
  7. Pin numpy to 1.21.5 since 1.22 introduces typing bugs

@ravi-mosaicml
Fixed pyright issues
aff8772 
1. Updated pyright version to 1.1.202
2.  Made the pyproject.toml slightly stricter. Added warnings for untyped function signatures and implicit string concat, which should later be converted to errors.
3. Removed unused variables and made those errors.
4. Set all instance variables on `__init__`
5. Fixed implicit None in signatures
@moinnadeem moinnadeem self-requested a review January 3, 2022 21:08
@moinnadeem
Copy link
Contributor

LGTM!

@ravi-mosaicml ravi-mosaicml merged commit 2c46659 into dev Jan 3, 2022
@ravi-mosaicml ravi-mosaicml deleted the ravi/fix_pyright branch January 3, 2022 22:24
coryMosaicML pushed a commit to coryMosaicML/composer that referenced this pull request Feb 23, 2022
@ravi-mosaicml @coryMosaicML
Fixed pyright issues (mosaicml#198)
e0a3632 
- Updated pyright version to 1.1.203
- Update python for github tests to 3.9
- Made the pyproject.toml slightly stricter. Added warnings for untyped function signatures and implicit string concat, which should later be converted to errors.
- Removed unused variables and made those errors.
- Set all instance variables on `__init__`
- Fixed implicit None in signatures
Pin numpy to 1.21.5 since 1.22 introduces typing bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moinnadeem moinnadeem moinnadeem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ravi-mosaicml @moinnadeem