Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed pyright issues #198

Merged
merged 12 commits into from
Jan 3, 2022
Merged

Fixed pyright issues #198

merged 12 commits into from
Jan 3, 2022

Commits on Jan 3, 2022

  1. Fixed pyright issues 

    1. Updated pyright version to 1.1.202
2.  Made the pyproject.toml slightly stricter. Added warnings for untyped function signatures and implicit string concat, which should later be converted to errors.
3. Removed unused variables and made those errors.
4. Set all instance variables on `__init__`
5. Fixed implicit None in signatures
    @ravi-mosaicml
    ravi-mosaicml committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    aff8772 View commit details
    Browse the repository at this point in the history

  2. YAPF fixes

    @ravi-mosaicml
    ravi-mosaicml committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    ca074a5 View commit details
    Browse the repository at this point in the history

  3. Downgrade pyright

    @ravi-mosaicml
    ravi-mosaicml committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    3862b22 View commit details
    Browse the repository at this point in the history

  4. Upgrade python version

    @ravi-mosaicml
    ravi-mosaicml committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    cfd536d View commit details
    Browse the repository at this point in the history

  5. Downgrade pyright

    @ravi-mosaicml
    ravi-mosaicml committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    8b0c4ad View commit details
    Browse the repository at this point in the history

  6. Downgrade pyright

    @ravi-mosaicml
    ravi-mosaicml committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    d1a29c1 View commit details
    Browse the repository at this point in the history

  7. Upgrade pyright

    @ravi-mosaicml
    ravi-mosaicml committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    22c3da5 View commit details
    Browse the repository at this point in the history

  8. Pinning numpy version 

    Numpy 1.22 has bad typing annotations
    @ravi-mosaicml
    ravi-mosaicml committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    5ab1f0e View commit details
    Browse the repository at this point in the history

  9. Fixed setup.py formatting

    @ravi-mosaicml
    ravi-mosaicml committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    d1d7056 View commit details
    Browse the repository at this point in the history

  10. Pin numpy

    @ravi-mosaicml
    ravi-mosaicml committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    5522cf3 View commit details
    Browse the repository at this point in the history

  11. Fixed the type ignore comment

    @ravi-mosaicml
    ravi-mosaicml committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    1a5d690 View commit details
    Browse the repository at this point in the history

  12. Fixed type ignore line

    @ravi-mosaicml
    ravi-mosaicml committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    7af4c13 View commit details
    Browse the repository at this point in the history