Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed pyright issues #198

Merged
merged 12 commits into from
Jan 3, 2022
Merged

Fixed pyright issues #198

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
aff8772
Fixed pyright issues
ravi-mosaicml Jan 3, 2022
ca074a5
YAPF fixes
ravi-mosaicml Jan 3, 2022
3862b22
Downgrade pyright
ravi-mosaicml Jan 3, 2022
cfd536d
Upgrade python version
ravi-mosaicml Jan 3, 2022
8b0c4ad
Downgrade pyright
ravi-mosaicml Jan 3, 2022
d1a29c1
Downgrade pyright
ravi-mosaicml Jan 3, 2022
22c3da5
Upgrade pyright
ravi-mosaicml Jan 3, 2022
5ab1f0e
Pinning numpy version
ravi-mosaicml Jan 3, 2022
d1d7056
Fixed setup.py formatting
ravi-mosaicml Jan 3, 2022
5522cf3
Pin numpy
ravi-mosaicml Jan 3, 2022
1a5d690
Fixed the type ignore comment
ravi-mosaicml Jan 3, 2022
7af4c13
Fixed type ignore line
ravi-mosaicml Jan 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed type ignore line
  • Loading branch information
@ravi-mosaicml
ravi-mosaicml committed Jan 3, 2022
commit 7af4c13e2c118ef39c1c2849ad275960718fa190
4 changes: 2 additions & 2 deletions composer/datasets/lm_datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ class LMDatasetHparams(DatasetHparams):

# TODO(moin): Switch datadir to be a string, rather than a list of strings, to be similar to the
# other datasets
datadir: List[str] = hp.optional("Path to the Huggingface Datasets directory.", # type: ignore
default_factory=list)
datadir: List[str] = hp.optional( # type: ignore
"Path to the Huggingface Datasets directory.", default_factory=list)
split: Optional[str] = hp.optional("Whether to use 'train', 'validation' or 'test' split.", default=None)
tokenizer_name: Optional[str] = hp.optional("The name of the tokenizer to preprocess text with.", default=None)
num_tokens: int = hp.optional(doc='If desired, the number of tokens to truncate the dataset to.', default=0)
Expand Down