[discover] update interfaces and move dataset manager #7745

kavilla · 2024-08-18T12:01:24Z

Updating the discover interfaces and move dataset manager into the proper location within the querystring manager.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

github-actions · 2024-08-18T12:01:55Z

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

codecov · 2024-08-18T12:15:35Z

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 45.87%. Comparing base (4e3c441) to head (be0002c).
Report is 1 commits behind head on feature/discover-interfaces.

Files	Patch %	Lines
...ry/query_string/dataset_manager/dataset_manager.ts	0.00%	11 Missing ⚠️
.../public/query/query_string/query_string_manager.ts	0.00%	3 Missing ⚠️
...ery_string/dataset_manager/dataset_manager.mock.ts	33.33%	2 Missing ⚠️
...query/state_sync/create_global_query_observable.ts	0.00%	2 Missing ⚠️
src/plugins/data/public/query/query_service.ts	0.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4e3c441) and HEAD (be0002c). Click for more details.

HEAD has 2 uploads less than BASE

Flag BASE (4e3c441) HEAD (be0002c)

Windows_4 1 0

Windows_3 1 0

Additional details and impacted files

@@                       Coverage Diff                        @@
##           feature/discover-interfaces    #7745       +/-   ##
================================================================
- Coverage                        63.80%   45.87%   -17.94%     
================================================================
  Files                             3650     2743      -907     
  Lines                            80965    62495    -18470     
  Branches                         12893     9767     -3126     
================================================================
- Hits                             51659    28667    -22992     
- Misses                           26137    32558     +6421     
+ Partials                          3169     1270     -1899

Flag	Coverage Δ
Linux_2	`55.84% <ø> (-0.02%)`	⬇️
Windows_1	`29.17% <5.00%> (-0.89%)`	⬇️
Windows_2	`55.80% <ø> (-0.02%)`	⬇️
Windows_3	`?`
Windows_4	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

kavilla · 2024-08-18T12:33:08Z

src/plugins/data/common/datasets/types.ts

  type: string;
  /** Optional reference to the parent data structure */
  parent?: DataStructure;
  /** Optional array of child data structures */
  children?: DataStructure[];
+  /** Optional metadata for the data structure */
+  meta?: DataStructureMeta;


do we think it makes sense to have the dataset just have a datastructure property instead of a datasource property? and we can construct the datasource from the datastructure?

The data source type has the connection details as well. Data structure requires 2 objects to show cluster and connection details and makes the reference bigger when you store it in the url

Yeah that makes sense. Will keep as is.

I do like the data structure object. Thanks for the clever idea @ashwin-pc. Seems super obvious that data sources and connections are types of data structures and gives us a flexible framework.

github-actions · 2024-08-18T12:34:36Z

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

ashwin-pc · 2024-08-18T17:06:40Z

src/plugins/data/common/datasets/types.ts

  type: string;
  /** Optional reference to the parent data structure */
  parent?: DataStructure;
  /** Optional array of child data structures */
  children?: DataStructure[];
+  /** Optional metadata for the data structure */
+  meta?: DataStructureMeta;


The data source type has the connection details as well. Data structure requires 2 objects to show cluster and connection details and makes the reference bigger when you store it in the url

src/plugins/data/common/datasets/types.ts

ashwin-pc · 2024-08-18T17:13:29Z

src/plugins/data/public/query/query_string/query_string_manager.ts

+    return this.datasetManager;
+  };
+
+  // TODO: uncomment or use based on decision above


No need to re expose the same functions. It'll just add unnecessary boilerplate

Make sense. Wasn't sure how Sean wanted to approach it so we can delete it. will be able to delete in a few hours if this doesn't get merged by then

Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Move dataset location Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update interfaces Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Update src/plugins/data/common/datasets/types.ts Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com>

…ject#7745) * Move dataset location Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update interfaces Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Update src/plugins/data/common/datasets/types.ts Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com>

* Move dataset location Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update interfaces Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Update src/plugins/data/common/datasets/types.ts Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com>

…ges (#7731) * Initial updates to new interfaces Discover expects Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [discover] update interfaces and move dataset manager (#7745) * Move dataset location Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update interfaces Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Update src/plugins/data/common/datasets/types.ts Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> * fix rebase errors Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [discover] update interfaces and selector (#7835) * dataset handler and move manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Adds new Data selector Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> fixes loading state Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * start wiring into the selector Signed-off-by: Kawika Avilla <kavilla414@gmail.com> no more white screen Signed-off-by: Kawika Avilla <kavilla414@gmail.com> updating handler Signed-off-by: Kawika Avilla <kavilla414@gmail.com> rendering data Signed-off-by: Kawika Avilla <kavilla414@gmail.com> data structures working ok Signed-off-by: Kawika Avilla <kavilla414@gmail.com> need to add datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> clean up Signed-off-by: Kawika Avilla <kavilla414@gmail.com> deleted unneeded types Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still working on the data structure and field Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still not working. the leaf logic isnt right i believe Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * indices Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * pushing datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fixes with column Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * working creation step Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * get dataset from state in use index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dataset selector working Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update ppl interceptor Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * add dataset service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * wired up but the dataset is off Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address review comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dql and lucene working again Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix issue that would deselect dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language switches and sets the query correctly Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * upating query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the styling a little Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * little bit width Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * submit on update Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix sql Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl working better Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * need to still fix the aggregations Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * gotta fix the aggs and still need to update dql lucene dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * use patch Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Metadata slice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * index pattern updates Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * types and datasource prepend Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> * Use language service to render query editor (#7848) * progress Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of setting class Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * register editor inside language Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address commits Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address more comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change editor Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * minor fixes (#7850) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [discover] Updates to mocks for tests and ci (#7852) * update manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Extension passing Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * mock getIndexPatterns Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * include create and save Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Fix Nav Bar layout in New Discover (#7853) * Fix Nav Bar layout in New Discover Signed-off-by: Suchit Sahoo <suchsah@amazon.com> * Changeset file for PR #7853 created/updated --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [discover] keep fixing mocks (#7855) * Updating mocks still Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Keep fixing mocks Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update to not use getter Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the query being updated twice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix remaining failures Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * manual changelog Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Co-authored-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…ges (opensearch-project#7731) * Initial updates to new interfaces Discover expects Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [discover] update interfaces and move dataset manager (opensearch-project#7745) * Move dataset location Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update interfaces Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Update src/plugins/data/common/datasets/types.ts Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> * fix rebase errors Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [discover] update interfaces and selector (opensearch-project#7835) * dataset handler and move manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Adds new Data selector Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> fixes loading state Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * start wiring into the selector Signed-off-by: Kawika Avilla <kavilla414@gmail.com> no more white screen Signed-off-by: Kawika Avilla <kavilla414@gmail.com> updating handler Signed-off-by: Kawika Avilla <kavilla414@gmail.com> rendering data Signed-off-by: Kawika Avilla <kavilla414@gmail.com> data structures working ok Signed-off-by: Kawika Avilla <kavilla414@gmail.com> need to add datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> clean up Signed-off-by: Kawika Avilla <kavilla414@gmail.com> deleted unneeded types Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still working on the data structure and field Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still not working. the leaf logic isnt right i believe Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * indices Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * pushing datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fixes with column Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * working creation step Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * get dataset from state in use index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dataset selector working Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update ppl interceptor Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * add dataset service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * wired up but the dataset is off Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address review comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dql and lucene working again Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix issue that would deselect dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language switches and sets the query correctly Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * upating query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the styling a little Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * little bit width Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * submit on update Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix sql Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl working better Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * need to still fix the aggregations Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * gotta fix the aggs and still need to update dql lucene dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * use patch Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Metadata slice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * index pattern updates Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * types and datasource prepend Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> * Use language service to render query editor (opensearch-project#7848) * progress Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of setting class Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * register editor inside language Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address commits Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address more comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change editor Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * minor fixes (opensearch-project#7850) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [discover] Updates to mocks for tests and ci (opensearch-project#7852) * update manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Extension passing Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * mock getIndexPatterns Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * include create and save Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Fix Nav Bar layout in New Discover (opensearch-project#7853) * Fix Nav Bar layout in New Discover Signed-off-by: Suchit Sahoo <suchsah@amazon.com> * Changeset file for PR opensearch-project#7853 created/updated --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [discover] keep fixing mocks (opensearch-project#7855) * Updating mocks still Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Keep fixing mocks Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update to not use getter Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the query being updated twice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix remaining failures Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * manual changelog Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Co-authored-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 1976ecf)

…ges (#7731) (#7863) * Initial updates to new interfaces Discover expects Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [discover] update interfaces and move dataset manager (#7745) * Move dataset location Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update interfaces Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Update src/plugins/data/common/datasets/types.ts Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> * fix rebase errors Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [discover] update interfaces and selector (#7835) * dataset handler and move manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Adds new Data selector Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> fixes loading state Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * start wiring into the selector Signed-off-by: Kawika Avilla <kavilla414@gmail.com> no more white screen Signed-off-by: Kawika Avilla <kavilla414@gmail.com> updating handler Signed-off-by: Kawika Avilla <kavilla414@gmail.com> rendering data Signed-off-by: Kawika Avilla <kavilla414@gmail.com> data structures working ok Signed-off-by: Kawika Avilla <kavilla414@gmail.com> need to add datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> clean up Signed-off-by: Kawika Avilla <kavilla414@gmail.com> deleted unneeded types Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still working on the data structure and field Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still not working. the leaf logic isnt right i believe Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * indices Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * pushing datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fixes with column Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * working creation step Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * get dataset from state in use index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dataset selector working Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update ppl interceptor Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * add dataset service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * wired up but the dataset is off Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address review comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dql and lucene working again Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix issue that would deselect dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language switches and sets the query correctly Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * upating query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the styling a little Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * little bit width Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * submit on update Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix sql Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl working better Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * need to still fix the aggregations Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * gotta fix the aggs and still need to update dql lucene dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * use patch Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Metadata slice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * index pattern updates Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * types and datasource prepend Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> * Use language service to render query editor (#7848) * progress Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of setting class Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * register editor inside language Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address commits Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address more comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change editor Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * minor fixes (#7850) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [discover] Updates to mocks for tests and ci (#7852) * update manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Extension passing Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * mock getIndexPatterns Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * include create and save Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Fix Nav Bar layout in New Discover (#7853) * Fix Nav Bar layout in New Discover Signed-off-by: Suchit Sahoo <suchsah@amazon.com> * Changeset file for PR #7853 created/updated --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [discover] keep fixing mocks (#7855) * Updating mocks still Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Keep fixing mocks Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update to not use getter Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the query being updated twice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix remaining failures Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * manual changelog Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Co-authored-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 1976ecf)

Move dataset location

4c94b68

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

kavilla added the discover-next label Aug 18, 2024

github-actions bot added the distinguished-contributor label Aug 18, 2024

github-actions bot added the failed changeset label Aug 18, 2024

update interfaces

91e8e5c

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

kavilla commented Aug 18, 2024

View reviewed changes

ashwin-pc approved these changes Aug 18, 2024

View reviewed changes

Update src/plugins/data/common/datasets/types.ts

be0002c

Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

kavilla merged commit 04b4784 into opensearch-project:feature/discover-interfaces Aug 18, 2024
22 of 66 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[discover] update interfaces and move dataset manager #7745

[discover] update interfaces and move dataset manager #7745

kavilla commented Aug 18, 2024 •

edited

Loading

github-actions bot commented Aug 18, 2024

codecov bot commented Aug 18, 2024 •

edited

Loading

kavilla Aug 18, 2024

ashwin-pc Aug 18, 2024

kavilla Aug 18, 2024

github-actions bot commented Aug 18, 2024

ashwin-pc Aug 18, 2024

ashwin-pc Aug 18, 2024

kavilla Aug 18, 2024

[discover] update interfaces and move dataset manager #7745

[discover] update interfaces and move dataset manager #7745

Conversation

kavilla commented Aug 18, 2024 • edited Loading

github-actions bot commented Aug 18, 2024

❌ Invalid Changelog Heading

codecov bot commented Aug 18, 2024 • edited Loading

Codecov Report

kavilla Aug 18, 2024

Choose a reason for hiding this comment

ashwin-pc Aug 18, 2024

Choose a reason for hiding this comment

kavilla Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 18, 2024

❌ Invalid Changelog Heading

ashwin-pc Aug 18, 2024

Choose a reason for hiding this comment

ashwin-pc Aug 18, 2024

Choose a reason for hiding this comment

kavilla Aug 18, 2024

Choose a reason for hiding this comment

kavilla commented Aug 18, 2024 •

edited

Loading

codecov bot commented Aug 18, 2024 •

edited

Loading