[discover] update interfaces and selector #7835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> fixes loading state Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com> no more white screen Signed-off-by: Kawika Avilla <kavilla414@gmail.com> updating handler Signed-off-by: Kawika Avilla <kavilla414@gmail.com> rendering data Signed-off-by: Kawika Avilla <kavilla414@gmail.com> data structures working ok Signed-off-by: Kawika Avilla <kavilla414@gmail.com> need to add datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> clean up Signed-off-by: Kawika Avilla <kavilla414@gmail.com> deleted unneeded types Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
requested review from
ananzh,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon and
zhongnansu
as code owners
kavilla
requested review from
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/discover-interfaces #7835 +/- ##
===============================================================
+ Coverage 45.88% 54.53% +8.64%
===============================================================
Files 2745 3259 +514
Lines 62581 71254 +8673
Branches 9783 10949 +1166
===============================================================
+ Hits 28716 38855 +10139
+ Misses 32592 30324 -2268
- Partials 1273 2075 +802
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
ashwin-pc
approved these changes
Aug 26, 2024
kavilla
merged commit 5e6e818
into
opensearch-project:feature/discover-interfaces
23 of 53 checks passed
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Aug 26, 2024
* dataset handler and move manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Adds new Data selector Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> fixes loading state Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * start wiring into the selector Signed-off-by: Kawika Avilla <kavilla414@gmail.com> no more white screen Signed-off-by: Kawika Avilla <kavilla414@gmail.com> updating handler Signed-off-by: Kawika Avilla <kavilla414@gmail.com> rendering data Signed-off-by: Kawika Avilla <kavilla414@gmail.com> data structures working ok Signed-off-by: Kawika Avilla <kavilla414@gmail.com> need to add datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> clean up Signed-off-by: Kawika Avilla <kavilla414@gmail.com> deleted unneeded types Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still working on the data structure and field Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still not working. the leaf logic isnt right i believe Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * indices Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * pushing datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fixes with column Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * working creation step Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * get dataset from state in use index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dataset selector working Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update ppl interceptor Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * add dataset service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * wired up but the dataset is off Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address review comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dql and lucene working again Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix issue that would deselect dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language switches and sets the query correctly Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * upating query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the styling a little Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * little bit width Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * submit on update Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix sql Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl working better Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * need to still fix the aggregations Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * gotta fix the aggs and still need to update dql lucene dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * use patch Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Metadata slice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * index pattern updates Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * types and datasource prepend Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
kavilla
added a commit
that referenced
this pull request
Aug 27, 2024
* dataset handler and move manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Adds new Data selector Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> fixes loading state Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * start wiring into the selector Signed-off-by: Kawika Avilla <kavilla414@gmail.com> no more white screen Signed-off-by: Kawika Avilla <kavilla414@gmail.com> updating handler Signed-off-by: Kawika Avilla <kavilla414@gmail.com> rendering data Signed-off-by: Kawika Avilla <kavilla414@gmail.com> data structures working ok Signed-off-by: Kawika Avilla <kavilla414@gmail.com> need to add datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> clean up Signed-off-by: Kawika Avilla <kavilla414@gmail.com> deleted unneeded types Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still working on the data structure and field Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still not working. the leaf logic isnt right i believe Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * indices Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * pushing datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fixes with column Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * working creation step Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * get dataset from state in use index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dataset selector working Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update ppl interceptor Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * add dataset service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * wired up but the dataset is off Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address review comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dql and lucene working again Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix issue that would deselect dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language switches and sets the query correctly Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * upating query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the styling a little Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * little bit width Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * submit on update Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix sql Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl working better Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * need to still fix the aggregations Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * gotta fix the aggs and still need to update dql lucene dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * use patch Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Metadata slice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * index pattern updates Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * types and datasource prepend Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
kavilla
added a commit
that referenced
this pull request
Aug 27, 2024
* dataset handler and move manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Adds new Data selector Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> fixes loading state Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * start wiring into the selector Signed-off-by: Kawika Avilla <kavilla414@gmail.com> no more white screen Signed-off-by: Kawika Avilla <kavilla414@gmail.com> updating handler Signed-off-by: Kawika Avilla <kavilla414@gmail.com> rendering data Signed-off-by: Kawika Avilla <kavilla414@gmail.com> data structures working ok Signed-off-by: Kawika Avilla <kavilla414@gmail.com> need to add datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> clean up Signed-off-by: Kawika Avilla <kavilla414@gmail.com> deleted unneeded types Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still working on the data structure and field Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still not working. the leaf logic isnt right i believe Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * indices Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * pushing datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fixes with column Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * working creation step Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * get dataset from state in use index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dataset selector working Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update ppl interceptor Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * add dataset service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * wired up but the dataset is off Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address review comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dql and lucene working again Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix issue that would deselect dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language switches and sets the query correctly Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * upating query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the styling a little Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * little bit width Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * submit on update Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix sql Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl working better Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * need to still fix the aggregations Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * gotta fix the aggs and still need to update dql lucene dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * use patch Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Metadata slice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * index pattern updates Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * types and datasource prepend Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
kavilla
added a commit
that referenced
this pull request
Aug 27, 2024
…ges (#7731) * Initial updates to new interfaces Discover expects Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [discover] update interfaces and move dataset manager (#7745) * Move dataset location Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update interfaces Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Update src/plugins/data/common/datasets/types.ts Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> * fix rebase errors Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [discover] update interfaces and selector (#7835) * dataset handler and move manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Adds new Data selector Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> fixes loading state Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * start wiring into the selector Signed-off-by: Kawika Avilla <kavilla414@gmail.com> no more white screen Signed-off-by: Kawika Avilla <kavilla414@gmail.com> updating handler Signed-off-by: Kawika Avilla <kavilla414@gmail.com> rendering data Signed-off-by: Kawika Avilla <kavilla414@gmail.com> data structures working ok Signed-off-by: Kawika Avilla <kavilla414@gmail.com> need to add datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> clean up Signed-off-by: Kawika Avilla <kavilla414@gmail.com> deleted unneeded types Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still working on the data structure and field Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still not working. the leaf logic isnt right i believe Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * indices Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * pushing datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fixes with column Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * working creation step Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * get dataset from state in use index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dataset selector working Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update ppl interceptor Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * add dataset service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * wired up but the dataset is off Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address review comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dql and lucene working again Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix issue that would deselect dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language switches and sets the query correctly Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * upating query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the styling a little Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * little bit width Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * submit on update Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix sql Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl working better Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * need to still fix the aggregations Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * gotta fix the aggs and still need to update dql lucene dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * use patch Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Metadata slice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * index pattern updates Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * types and datasource prepend Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> * Use language service to render query editor (#7848) * progress Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of setting class Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * register editor inside language Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address commits Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address more comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change editor Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * minor fixes (#7850) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [discover] Updates to mocks for tests and ci (#7852) * update manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Extension passing Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * mock getIndexPatterns Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * include create and save Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Fix Nav Bar layout in New Discover (#7853) * Fix Nav Bar layout in New Discover Signed-off-by: Suchit Sahoo <suchsah@amazon.com> * Changeset file for PR #7853 created/updated --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [discover] keep fixing mocks (#7855) * Updating mocks still Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Keep fixing mocks Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update to not use getter Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the query being updated twice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix remaining failures Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * manual changelog Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Co-authored-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Aug 27, 2024
…ges (opensearch-project#7731) * Initial updates to new interfaces Discover expects Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [discover] update interfaces and move dataset manager (opensearch-project#7745) * Move dataset location Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update interfaces Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Update src/plugins/data/common/datasets/types.ts Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> * fix rebase errors Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [discover] update interfaces and selector (opensearch-project#7835) * dataset handler and move manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Adds new Data selector Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> fixes loading state Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * start wiring into the selector Signed-off-by: Kawika Avilla <kavilla414@gmail.com> no more white screen Signed-off-by: Kawika Avilla <kavilla414@gmail.com> updating handler Signed-off-by: Kawika Avilla <kavilla414@gmail.com> rendering data Signed-off-by: Kawika Avilla <kavilla414@gmail.com> data structures working ok Signed-off-by: Kawika Avilla <kavilla414@gmail.com> need to add datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> clean up Signed-off-by: Kawika Avilla <kavilla414@gmail.com> deleted unneeded types Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still working on the data structure and field Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still not working. the leaf logic isnt right i believe Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * indices Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * pushing datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fixes with column Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * working creation step Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * get dataset from state in use index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dataset selector working Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update ppl interceptor Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * add dataset service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * wired up but the dataset is off Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address review comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dql and lucene working again Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix issue that would deselect dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language switches and sets the query correctly Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * upating query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the styling a little Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * little bit width Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * submit on update Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix sql Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl working better Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * need to still fix the aggregations Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * gotta fix the aggs and still need to update dql lucene dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * use patch Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Metadata slice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * index pattern updates Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * types and datasource prepend Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> * Use language service to render query editor (opensearch-project#7848) * progress Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of setting class Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * register editor inside language Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address commits Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address more comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change editor Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * minor fixes (opensearch-project#7850) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [discover] Updates to mocks for tests and ci (opensearch-project#7852) * update manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Extension passing Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * mock getIndexPatterns Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * include create and save Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Fix Nav Bar layout in New Discover (opensearch-project#7853) * Fix Nav Bar layout in New Discover Signed-off-by: Suchit Sahoo <suchsah@amazon.com> * Changeset file for PR opensearch-project#7853 created/updated --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [discover] keep fixing mocks (opensearch-project#7855) * Updating mocks still Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Keep fixing mocks Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update to not use getter Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the query being updated twice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix remaining failures Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * manual changelog Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Co-authored-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 1976ecf)
ashwin-pc
pushed a commit
that referenced
this pull request
Aug 27, 2024
…ges (#7731) (#7863) * Initial updates to new interfaces Discover expects Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [discover] update interfaces and move dataset manager (#7745) * Move dataset location Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update interfaces Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Update src/plugins/data/common/datasets/types.ts Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> * fix rebase errors Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [discover] update interfaces and selector (#7835) * dataset handler and move manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Adds new Data selector Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> fixes loading state Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * start wiring into the selector Signed-off-by: Kawika Avilla <kavilla414@gmail.com> no more white screen Signed-off-by: Kawika Avilla <kavilla414@gmail.com> updating handler Signed-off-by: Kawika Avilla <kavilla414@gmail.com> rendering data Signed-off-by: Kawika Avilla <kavilla414@gmail.com> data structures working ok Signed-off-by: Kawika Avilla <kavilla414@gmail.com> need to add datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> clean up Signed-off-by: Kawika Avilla <kavilla414@gmail.com> deleted unneeded types Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still working on the data structure and field Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still not working. the leaf logic isnt right i believe Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * indices Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * pushing datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fixes with column Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * working creation step Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * get dataset from state in use index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dataset selector working Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update ppl interceptor Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * add dataset service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * wired up but the dataset is off Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address review comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dql and lucene working again Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix issue that would deselect dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language switches and sets the query correctly Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * upating query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the styling a little Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * little bit width Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * submit on update Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix sql Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl working better Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * need to still fix the aggregations Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * gotta fix the aggs and still need to update dql lucene dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * use patch Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Metadata slice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * index pattern updates Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * types and datasource prepend Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> * Use language service to render query editor (#7848) * progress Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of setting class Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * register editor inside language Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address commits Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address more comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change editor Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * minor fixes (#7850) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [discover] Updates to mocks for tests and ci (#7852) * update manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Extension passing Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * mock getIndexPatterns Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * include create and save Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Fix Nav Bar layout in New Discover (#7853) * Fix Nav Bar layout in New Discover Signed-off-by: Suchit Sahoo <suchsah@amazon.com> * Changeset file for PR #7853 created/updated --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [discover] keep fixing mocks (#7855) * Updating mocks still Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Keep fixing mocks Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update to not use getter Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the query being updated twice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix remaining failures Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * manual changelog Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Co-authored-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 1976ecf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration