-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use language service to render query editor #7848
Use language service to render query editor #7848
Conversation
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/discover-interfaces #7848 +/- ##
===============================================================
- Coverage 54.58% 54.56% -0.02%
===============================================================
Files 3267 3268 +1
Lines 71555 71540 -15
Branches 11022 11021 -1
===============================================================
- Hits 39055 39037 -18
- Misses 30413 30418 +5
+ Partials 2087 2085 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
notifications: { toasts }, | ||
application, | ||
}, | ||
} = useOpenSearchDashboards<DataExplorerServices>(); | ||
|
||
useEffect(() => { | ||
const subscriptions = ui.Settings.getEnabledQueryEnhancementsUpdated$().subscribe( | ||
(enabledQueryEnhancements) => { | ||
const subscriptions = queryString |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we can clean more of this file and all we really need it to do is check the ui settings if enhancements enabled. if enhancements enabled don't show the other selector
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follows up for more cleaning but this is nice already. merging . future prs can target main
058b041
into
opensearch-project:feature/discover-interfaces
return this.queryEditorExtensionMap; | ||
} | ||
|
||
resetUserQuery() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think we call this anywhere right we should look to call this when it gets toggled off. in the query enhancements plugin we can listen to the ui settings and reset query if enhancements is false
collapsedProps: any, | ||
expandedProps: any, | ||
bodyProps: any | ||
) => EditorInstance<any, any, any>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast follow, export types and use them.
collapsedProps: any, | ||
expandedProps: any, | ||
bodyProps: any | ||
) => EditorInstance<any, any, any>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: i think this could be optional. if they don't pass in an editor we use the default editor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast follow: export the default Editor, or required components
@@ -46,6 +39,10 @@ export { | |||
QueryEditorExtensions, | |||
QueryEditorExtensionDependencies, | |||
QueryEditorExtensionConfig, | |||
createEditor, | |||
DefaultInput, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of exporting the type, export the createEditor from the ui service, and then you can also export the default input and single line input
@@ -27,7 +27,7 @@ interface DefaultInputProps extends React.JSX.IntrinsicAttributes { | |||
provideCompletionItems: monaco.languages.CompletionItemProvider['provideCompletionItems']; | |||
} | |||
|
|||
const DefaultInput: React.FC<DefaultInputProps> = ({ | |||
export const DefaultInput: React.FC<DefaultInputProps> = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like above don't need to export completing just make it possible to access the instantied component
@@ -57,8 +56,8 @@ export const QueryLanguageSelector = (props: QueryLanguageSelectorProps) => { | |||
|
|||
languageService.getLanguages().forEach((language) => { | |||
if ( | |||
(language && props.appName && !language.supportedAppNames.includes(props.appName)) || | |||
uiService.Settings.getUserQueryLanguageBlocklist().includes(language?.id) | |||
(language && props.appName && !language.editorSupportedAppNames?.includes(props.appName)) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: i think we can clean this up. language select should already dispalyed when its in a supported app nap
(language && props.appName && !language.supportedAppNames.includes(props.appName)) || | ||
uiService.Settings.getUserQueryLanguageBlocklist().includes(language?.id) | ||
(language && props.appName && !language.editorSupportedAppNames?.includes(props.appName)) || | ||
languageService.getUserQueryLanguageBlocklist().includes(language?.id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here is where we can probably modify this to ensure that the language service.getlanguages for each language only returns backs languages that are available from the dataset.
tldr: we should just getLanguages return back already filtered instead of the lagnuage selector handling this
const languageEditor = useQueryEditor | ||
? createDefaultEditor(singleLineInputProps, {}, defaultInputProps) | ||
: createDQLEditor(singleLineInputProps, singleLineInputProps, { | ||
? languageEditorFunc(singleLineInputProps, {}, defaultInputProps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like above i think this should already being the editor wired up with state but will need to export it properly from the UI service.
can be a clean up follow up non blocker
* progress Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of setting class Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * register editor inside language Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address commits Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address more comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change editor Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
* progress Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of setting class Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * register editor inside language Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address commits Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address more comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change editor Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
…ges (#7731) * Initial updates to new interfaces Discover expects Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [discover] update interfaces and move dataset manager (#7745) * Move dataset location Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update interfaces Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Update src/plugins/data/common/datasets/types.ts Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> * fix rebase errors Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [discover] update interfaces and selector (#7835) * dataset handler and move manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Adds new Data selector Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> fixes loading state Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * start wiring into the selector Signed-off-by: Kawika Avilla <kavilla414@gmail.com> no more white screen Signed-off-by: Kawika Avilla <kavilla414@gmail.com> updating handler Signed-off-by: Kawika Avilla <kavilla414@gmail.com> rendering data Signed-off-by: Kawika Avilla <kavilla414@gmail.com> data structures working ok Signed-off-by: Kawika Avilla <kavilla414@gmail.com> need to add datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> clean up Signed-off-by: Kawika Avilla <kavilla414@gmail.com> deleted unneeded types Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still working on the data structure and field Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still not working. the leaf logic isnt right i believe Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * indices Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * pushing datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fixes with column Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * working creation step Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * get dataset from state in use index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dataset selector working Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update ppl interceptor Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * add dataset service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * wired up but the dataset is off Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address review comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dql and lucene working again Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix issue that would deselect dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language switches and sets the query correctly Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * upating query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the styling a little Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * little bit width Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * submit on update Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix sql Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl working better Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * need to still fix the aggregations Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * gotta fix the aggs and still need to update dql lucene dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * use patch Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Metadata slice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * index pattern updates Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * types and datasource prepend Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> * Use language service to render query editor (#7848) * progress Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of setting class Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * register editor inside language Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address commits Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address more comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change editor Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * minor fixes (#7850) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [discover] Updates to mocks for tests and ci (#7852) * update manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Extension passing Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * mock getIndexPatterns Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * include create and save Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Fix Nav Bar layout in New Discover (#7853) * Fix Nav Bar layout in New Discover Signed-off-by: Suchit Sahoo <suchsah@amazon.com> * Changeset file for PR #7853 created/updated --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [discover] keep fixing mocks (#7855) * Updating mocks still Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Keep fixing mocks Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update to not use getter Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the query being updated twice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix remaining failures Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * manual changelog Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Co-authored-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…ges (opensearch-project#7731) * Initial updates to new interfaces Discover expects Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [discover] update interfaces and move dataset manager (opensearch-project#7745) * Move dataset location Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update interfaces Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Update src/plugins/data/common/datasets/types.ts Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> * fix rebase errors Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [discover] update interfaces and selector (opensearch-project#7835) * dataset handler and move manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Adds new Data selector Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> fixes loading state Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * start wiring into the selector Signed-off-by: Kawika Avilla <kavilla414@gmail.com> no more white screen Signed-off-by: Kawika Avilla <kavilla414@gmail.com> updating handler Signed-off-by: Kawika Avilla <kavilla414@gmail.com> rendering data Signed-off-by: Kawika Avilla <kavilla414@gmail.com> data structures working ok Signed-off-by: Kawika Avilla <kavilla414@gmail.com> need to add datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> clean up Signed-off-by: Kawika Avilla <kavilla414@gmail.com> deleted unneeded types Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still working on the data structure and field Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still not working. the leaf logic isnt right i believe Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * indices Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * pushing datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fixes with column Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * working creation step Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * get dataset from state in use index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dataset selector working Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update ppl interceptor Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * add dataset service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * wired up but the dataset is off Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address review comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dql and lucene working again Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix issue that would deselect dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language switches and sets the query correctly Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * upating query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the styling a little Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * little bit width Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * submit on update Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix sql Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl working better Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * need to still fix the aggregations Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * gotta fix the aggs and still need to update dql lucene dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * use patch Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Metadata slice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * index pattern updates Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * types and datasource prepend Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> * Use language service to render query editor (opensearch-project#7848) * progress Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of setting class Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * register editor inside language Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address commits Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address more comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change editor Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * minor fixes (opensearch-project#7850) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [discover] Updates to mocks for tests and ci (opensearch-project#7852) * update manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Extension passing Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * mock getIndexPatterns Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * include create and save Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Fix Nav Bar layout in New Discover (opensearch-project#7853) * Fix Nav Bar layout in New Discover Signed-off-by: Suchit Sahoo <suchsah@amazon.com> * Changeset file for PR opensearch-project#7853 created/updated --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [discover] keep fixing mocks (opensearch-project#7855) * Updating mocks still Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Keep fixing mocks Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update to not use getter Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the query being updated twice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix remaining failures Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * manual changelog Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Co-authored-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 1976ecf)
…ges (#7731) (#7863) * Initial updates to new interfaces Discover expects Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [discover] update interfaces and move dataset manager (#7745) * Move dataset location Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update interfaces Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Update src/plugins/data/common/datasets/types.ts Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> * fix rebase errors Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [discover] update interfaces and selector (#7835) * dataset handler and move manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Adds new Data selector Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> fixes loading state Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * start wiring into the selector Signed-off-by: Kawika Avilla <kavilla414@gmail.com> no more white screen Signed-off-by: Kawika Avilla <kavilla414@gmail.com> updating handler Signed-off-by: Kawika Avilla <kavilla414@gmail.com> rendering data Signed-off-by: Kawika Avilla <kavilla414@gmail.com> data structures working ok Signed-off-by: Kawika Avilla <kavilla414@gmail.com> need to add datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> clean up Signed-off-by: Kawika Avilla <kavilla414@gmail.com> deleted unneeded types Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still working on the data structure and field Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * still not working. the leaf logic isnt right i believe Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * indices Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * pushing datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fixes with column Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * working creation step Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * get dataset from state in use index pattern Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dataset selector working Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update ppl interceptor Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * add dataset service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language service Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * wired up but the dataset is off Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address review comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * dql and lucene working again Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix issue that would deselect dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * language switches and sets the query correctly Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * upating query Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the styling a little Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * little bit width Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * submit on update Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix sql Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * ppl working better Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * need to still fix the aggregations Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * gotta fix the aggs and still need to update dql lucene dataset Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * use patch Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Metadata slice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * index pattern updates Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * types and datasource prepend Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> * Use language service to render query editor (#7848) * progress Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of setting class Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * register editor inside language Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address commits Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address more comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change editor Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * minor fixes (#7850) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [discover] Updates to mocks for tests and ci (#7852) * update manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Extension passing Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * mock getIndexPatterns Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * include create and save Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Fix Nav Bar layout in New Discover (#7853) * Fix Nav Bar layout in New Discover Signed-off-by: Suchit Sahoo <suchsah@amazon.com> * Changeset file for PR #7853 created/updated --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [discover] keep fixing mocks (#7855) * Updating mocks still Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Keep fixing mocks Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update to not use getter Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix the query being updated twice Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix remaining failures Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * manual changelog Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Co-authored-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 1976ecf)
Description
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration