Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/reference, v3.0/reference, v2.1/reference: add safe-mode config in binlog reparo doc #1558

Merged
merged 15 commits into from
Jul 12, 2019
Merged

dev/reference, v3.0/reference, v2.1/reference: add safe-mode config in binlog reparo doc #1558

merged 15 commits into from
Jul 12, 2019

Conversation

ericsyh
Copy link
Contributor

@ericsyh ericsyh commented Jul 2, 2019

What is changed, added or deleted?

In pingcap/tidb-binlog#652 we add a new config safe-mode in reparo, this PR this to update the reparo documents about the new config.

What is the related PR or file link(s)?

In pingcap/tidb-binlog#652.

Which version does your change affect?

Apply in dev/v3.0/v2.1

@yikeke
Copy link
Contributor

yikeke commented Jul 9, 2019

Important Update: We have added a markdownlint static check in the CI check to improve the quality of our documentation, so your unclosed PR might fail the CI check now.

First, you should merge upstream master to your branch, so the upstream changes might resolve the issues found by the CI check. Then, click details beside the ci/circleci: lint — Your tests failed on CircleCI message, and you can check the details for the failure and fix all the issues in your PR. It is recommended to install "markdownlint" extension in your VS Code editor, so it will check all potential issues that fail the CI check.

@ericsyh If you have any problem with troubleshooting, please consult @yikeke for help. Thanks for your cooperation~

Ref: #1494

@WangXiangUSTC
Copy link
Contributor

LGTM

@yikeke yikeke requested review from yikeke and removed request for lilin90 July 10, 2019 07:20
@yikeke yikeke requested review from lilin90 and removed request for yikeke July 10, 2019 07:22
@yikeke
Copy link
Contributor

yikeke commented Jul 12, 2019

Please remove the hard tab in the Line 36 of the changed dev/reference/tools/tidb-binlog/reparo.md file, so your pull request can pass the CI check. Thanks~ @ericsyh

@ericsyh
Copy link
Contributor Author

ericsyh commented Jul 12, 2019

Okay, i will fix it.

dev/reference/tools/tidb-binlog/reparo.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-binlog/reparo.md Outdated Show resolved Hide resolved
v2.1/reference/tools/tidb-binlog/reparo.md Outdated Show resolved Hide resolved
v2.1/reference/tools/tidb-binlog/reparo.md Outdated Show resolved Hide resolved
v3.0/reference/tools/tidb-binlog/reparo.md Outdated Show resolved Hide resolved
v3.0/reference/tools/tidb-binlog/reparo.md Outdated Show resolved Hide resolved
@yikeke yikeke changed the title dev/reference, v3.0/reference, v2.1/reference: binlog reparo add safe-mode config in doc dev/reference, v3.0/reference, v2.1/reference: add safe-mode config in binlog reparo doc Jul 12, 2019
ericsyh and others added 5 commits July 12, 2019 15:24
apply

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
apply

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
apply

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
apply

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
apply

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
apply

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsyh ericsyh merged commit a906a30 into pingcap:master Jul 12, 2019
@ericsyh ericsyh deleted the binlog-reparo-add-config branch July 13, 2019 06:17
@lilin90 lilin90 added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants