Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev, v3.0, v2.1: add safe-mode config in binlog reparo doc (new) #1441

Merged
merged 1 commit into from
Aug 9, 2019
Merged

dev, v3.0, v2.1: add safe-mode config in binlog reparo doc (new) #1441

merged 1 commit into from
Aug 9, 2019

Conversation

junlan-zhang
Copy link
Contributor

What is changed, added or deleted?

  • Add a safe-mode config in binlog reparo doc

What is the related PR or file link(s)?

pingcap/docs-cn#1558 (original)
#1422 (with CLA error)

Which version does your change affect?

dev, v3.0, v2.1

Checklist

  • Add a new file to TOC.md
  • No Tab spaces anywhere
  • Leave a blank line both before and after a code block
  • Keep the first level heading consistent with title in metadata
  • Use four spaces for each level of indentation except that in TOC.md

TomShawn
TomShawn approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junlan-zhang junlan-zhang mentioned this pull request Aug 9, 2019
Closed
5 tasks
@junlan-zhang junlan-zhang changed the title dev/v3.0/v2.1: add large binlog operation FAQ (new) dev, v3.0, v2.1: add safe-mode config in binlog reparo doc (new) Aug 9, 2019
lilin90
lilin90 approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 9ff78a3 into pingcap:master Aug 9, 2019
@lilin90 lilin90 added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@TomShawn TomShawn TomShawn approved these changes

@ericsyh ericsyh Awaiting requested review from ericsyh

Assignees
No one assigned
Labels
translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junlan-zhang @lilin90 @TomShawn