Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev, v3.0, v2.1: add safe-mode config in binlog reparo doc #1422

Conversation

junlan-zhang
Copy link
Contributor

What is changed, added or deleted?

  • Add a safe-mode config in binlog reparo doc

What is the related PR or file link(s)?

pingcap/docs-cn#1558

Which version does your change affect?

dev, v3.0, v2.1

Checklist

  • Add a new file to TOC.md
  • No Tab spaces anywhere
  • Leave a blank line both before and after a code block
  • Keep the first level heading consistent with title in metadata
  • Use four spaces for each level of indentation except that in TOC.md

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also apply these changes to the dev and v3.0 versions.

dev/reference/tools/tidb-binlog/reparo.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-binlog/reparo.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-binlog/reparo.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-binlog/reparo.md Show resolved Hide resolved
dev/how-to/maintain/backup-and-restore.md Outdated Show resolved Hide resolved
junlan-zhang and others added 3 commits August 7, 2019 14:44
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
@lilin90 lilin90 changed the title Dev/v3.0/v2.1 add safe-mode config in binlog reparo doc dev/v3.0/v2.1 add safe-mode config in binlog reparo doc Aug 7, 2019
@lilin90 lilin90 changed the title dev/v3.0/v2.1 add safe-mode config in binlog reparo doc dev, v3.0, v2.1: add safe-mode config in binlog reparo doc Aug 7, 2019
@lilin90
Copy link
Member

lilin90 commented Aug 7, 2019

@ericsyh PTAL

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dev/reference/tools/tidb-binlog/reparo.md Outdated Show resolved Hide resolved
v2.1/reference/tools/tidb-binlog/reparo.md Outdated Show resolved Hide resolved
v3.0/reference/tools/tidb-binlog/reparo.md Outdated Show resolved Hide resolved
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@CLAassistant
Copy link

CLAassistant commented Aug 8, 2019

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ juliezhang1112
❌ Julie Zhang


Julie Zhang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@yikeke yikeke removed their request for review August 8, 2019 07:46
@ericsyh
Copy link
Contributor

ericsyh commented Aug 9, 2019

LGTM

@lilin90
Copy link
Member

lilin90 commented Aug 9, 2019

@juliezhang1112 Please sign the CLA. It seems that you used two accounts to commit.

@junlan-zhang
Copy link
Contributor Author

I create a PR just the same as this one due to the CLA error.
#1441

@lilin90 lilin90 added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants