Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data-Driven Keyboard Conversions: BastardKB #23622

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Data-Driven Keyboard Conversions: BastardKB #23622

merged 1 commit into from
Apr 27, 2024

Conversation

noroadsleft
Copy link
Member

Description

Converts rules.mk entries to data-driven where applicable.

  • keyboards with names beginning with bastardkb/

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft
Data-Driven Keyboard Conversions: BastardKB
b5e197b 
Converts `rules.mk` entries to data-driven where applicable.

Affects:

  - `bastardkb/charybdis/3x5/blackpill`
  - `bastardkb/charybdis/3x5/v1/elitec`
  - `bastardkb/charybdis/3x5/v2/elitec`
  - `bastardkb/charybdis/3x5/v2/splinky_2`
  - `bastardkb/charybdis/3x5/v2/splinky_3`
  - `bastardkb/charybdis/3x5/v2/stemcell`
  - `bastardkb/charybdis/3x6/blackpill`
  - `bastardkb/charybdis/3x6/v1/elitec`
  - `bastardkb/charybdis/3x6/v2/elitec`
  - `bastardkb/charybdis/3x6/v2/splinky_2`
  - `bastardkb/charybdis/3x6/v2/splinky_3`
  - `bastardkb/charybdis/3x6/v2/stemcell`
  - `bastardkb/charybdis/4x6/blackpill`
  - `bastardkb/charybdis/4x6/v1/elitec`
  - `bastardkb/charybdis/4x6/v2/elitec`
  - `bastardkb/charybdis/4x6/v2/splinky_2`
  - `bastardkb/charybdis/4x6/v2/splinky_3`
  - `bastardkb/charybdis/4x6/v2/stemcell`
  - `bastardkb/scylla/blackpill`
  - `bastardkb/scylla/v1/elitec`
  - `bastardkb/scylla/v2/elitec`
  - `bastardkb/scylla/v2/splinky_2`
  - `bastardkb/scylla/v2/splinky_3`
  - `bastardkb/scylla/v2/stemcell`
  - `bastardkb/skeletyl/blackpill`
  - `bastardkb/skeletyl/v1/elitec`
  - `bastardkb/skeletyl/v2/elitec`
  - `bastardkb/skeletyl/v2/splinky_2`
  - `bastardkb/skeletyl/v2/splinky_3`
  - `bastardkb/skeletyl/v2/stemcell`
@noroadsleft noroadsleft requested review from zvecr and a team April 27, 2024 05:09
@noroadsleft
Copy link
Member Author

Continuing from #23425 (comment):

re bastardkb: A removal of legacy variants and flattening the directory structure is planned - I have already begun work but need some more time and internal review; We should coordinate to avoid duplication of efforts.

@finrod09,

As you can see, I've already done my planned data-driven conversions for the BastardKB boards. I've posted this as a Draft so it can't be merged yet, so if you have anything to add or advise me about, now is the time. The repository closes to new non-bugfix PRs in a few days.

@finrod09
Copy link
Contributor

As you have already done the work, I have absolutely no objections. Thank you!

We have quite a few changes to upstream, and as I've been advised that we should separate PRs by board, there is quite a bit of commit reshuffling to do before we can start, which will take some more time; We unfortunately won't make it for this breaking changes cycle.

I will extend the DD conversions already done downstream to cover the full extent of your changes to make sure nothing gets lost.

@noroadsleft
Copy link
Member Author

This PR only converts rules.mk settings in the format of <feature>_ENABLE = yes and KEYBOARD_SHARED_EP = yes. Anything else will - at least in the interim - still remain in the rules.mk files.

@noroadsleft noroadsleft marked this pull request as ready for review April 27, 2024 08:31
@zvecr zvecr merged commit 569be59 into qmk:develop Apr 27, 2024
4 checks passed
@noroadsleft noroadsleft deleted the dev/dd_json_bastardkb branch April 27, 2024 18:25
This was referenced Apr 30, 2024
Merged
Open
This was referenced May 28, 2024
Open
Open
Open
Open
Open
Open
Open
Open
PepperLola pushed a commit to PepperLola/qmk_firmware that referenced this pull request May 29, 2024
@noroadsleft @PepperLola
Data-Driven Keyboard Conversions: BastardKB (qmk#23622)
7e27112
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@noroadsleft @whoisjordangarcia
Data-Driven Keyboard Conversions: BastardKB (qmk#23622)
e4a123d
nuphy-src pushed a commit to nuphy-src/qmk_firmware that referenced this pull request Jul 2, 2024
@noroadsleft @nuphy-src
Data-Driven Keyboard Conversions: BastardKB (qmk#23622)
d7469ec
jrtex pushed a commit to jrtex/qmk_firmware that referenced this pull request Jul 13, 2024
@noroadsleft
Data-Driven Keyboard Conversions: BastardKB (qmk#23622)
3b9b5bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@noroadsleft @finrod09 @fauxpark @zvecr