-
-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BastardKB: Upstream charybdis/3x5 #23638
Conversation
Also, just a heads up, you have a number of keyboard.json files removed. These replace info.json+rules.mk (eg, you only need the keyboard.json instead of those). So I/we would prefer if they were not removed, unless there is a specific reason for removing them. |
They have been removed as all revisions of the keyboard have been removed entirely - They have been deprecated for a considerable timeframe; Only the main keyboard, in the state that was previously the revision Please let me know if the final result is not to your specifications/expectations. |
Thank you for your contribution! |
As of August 26, 2024, As you've submitted a PR containing |
The BKB team has decided to stop upstreaming efforts at this time. |
Description
This change aims to upstream several changes accumulated in the BastardKB fork.
The most extensive of these changes is dropping support for all controllers and shields other than
v2/splinky_3
, which has been flattened into the main keyboard. Older variants have not been sold in kits or prebuilts nor been recommended to self-source for a long time.The dates GH shows on these commits is misleading as some rewriting of the history was necessary to separate commits by keyboard; The functional changes by @0xcharly have been shipping with kits and prebuilts for months and are well-tested. Changes up to and including 3799cd5 are live downstream.
Care has been taken to not lose changes introduced by #23622 and #23627.
Similar changes for all other BastardKB boards are ready, but not yet submitted to reduce the review burden, as they all follow a similar pattern.
Requesting comments.
The full set of related PRs is:
tbk
#23818Types of Changes
Issues Fixed or Closed by This PR
Checklist