Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BastardKB: upstream skeletyl #23812

Closed
wants to merge 10 commits into from
Closed

Conversation

burkfers
Copy link
Contributor

@burkfers burkfers commented May 28, 2024

Description

This change aims to upstream several changes accumulated in the BastardKB fork. It is submitted alondside several companion PRs, which divide the very similar set of changes by board. Changes requested during review of the initial draft have been appied here as well, where applicable.

The full set of related PRs is:

Description from the inital PR repeated for convenience:

The most extensive of these changes is dropping support for all controllers and shields other than v2/splinky_3, which has been flattened into the main keyboard. Older variants have not been sold in kits or prebuilts nor been recommended to self-source for a long time.

The dates GH shows on these commits is misleading as some rewriting of the history was necessary to separate commits by keyboard; The functional changes by @0xcharly have been shipping with kits and prebuilts for months and are well-tested. Changes up to and including 3799cd5 are live downstream.

Care has been taken to not lose changes introduced by #23622 and #23627.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team June 9, 2024 17:44
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 25, 2024
@drashna drashna added awaiting review and removed stale Issues or pull requests that have become inactive without resolution. labels Jul 26, 2024
@burkfers
Copy link
Contributor Author

The BKB team has decided to stop upstreaming efforts at this time.

@burkfers burkfers closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants