Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clippy #50889

Merged
merged 1 commit into from
May 20, 2018
Merged

Update clippy #50889

merged 1 commit into from
May 20, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented May 19, 2018

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 19, 2018
@kennytm
Copy link
Member

kennytm commented May 19, 2018

@bors r+

Note that RLS is still using clippy 0.0.200.

@bors
Copy link
Contributor

bors commented May 19, 2018

📌 Commit 387875d has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2018
@kennytm kennytm mentioned this pull request May 19, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request May 19, 2018
@kennytm
Rollup merge of rust-lang#50889 - oli-obk:clippy, r=kennytm
ada5fee 
Update clippy


# Conflicts:
#	src/Cargo.lock
bors added a commit that referenced this pull request May 19, 2018
@bors
Auto merge of #50893 - kennytm:rollup, r=kennytm
3ea2491 
Rollup of 8 pull requests

Successful merges:

 - #50531 (Cleanup uses of TypeIdHasher and replace them with StableHasher)
 - #50819 (Fix potential divide by zero)
 - #50827 (Update LLVM to 56c931901cfb85cd6f7ed44c7d7520a8de1edf97)
 - #50829 (CheckLoopVisitor: also visit break expressions)
 - #50854 (in which the unused shorthand field pattern debacle/saga continues)
 - #50858 (Reorder description for snippets in rustdoc documentation)
 - #50883 (Fix warning when building stage0 libcore)
 - #50889 (Update clippy)

Failed merges:
@bors bors merged commit 387875d into rust-lang:master May 20, 2018
@kennytm
Copy link
Member

kennytm commented May 20, 2018

Clippy is still build-fail.

[01:30:32] error[E0605]: non-primitive cast: `rustc_target::abi::Size` as `usize`
[01:30:32]    --> tools/clippy/clippy_lints/src/consts.rs:435:34
[01:30:32]     |
[01:30:32] 435 |                     let offset = ptr.offset as usize;
[01:30:32]     |                                  ^^^^^^^^^^^^^^^^^^^
[01:30:32]     |
[01:30:32]     = note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
[01:30:32]
[01:30:36] error: aborting due to previous error
[01:30:36]
[01:30:36] For more information about this error, try `rustc --explain E0605`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oli-obk @rust-highfive @kennytm @bors