-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .btn-subtle
variant
#38763
Closed
Closed
Add .btn-subtle
variant
#38763
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -150,6 +150,39 @@ | |
@include button-outline-variant($value); | ||
} | ||
} | ||
|
||
@each $color, $value in $theme-colors { | ||
.btn-subtle { | ||
@if $color == "light" { | ||
@include button-variant( | ||
$value, | ||
$value, | ||
$hover-background: shade-color($value, $btn-hover-bg-shade-amount), | ||
$hover-border: shade-color($value, $btn-hover-border-shade-amount), | ||
$active-background: shade-color($value, $btn-active-bg-shade-amount), | ||
$active-border: shade-color($value, $btn-active-border-shade-amount) | ||
); | ||
} @else if $color == "dark" { | ||
@include button-variant( | ||
$value, | ||
$value, | ||
$hover-background: tint-color($value, $btn-hover-bg-tint-amount), | ||
$hover-border: tint-color($value, $btn-hover-border-tint-amount), | ||
$active-background: tint-color($value, $btn-active-bg-tint-amount), | ||
$active-border: tint-color($value, $btn-active-border-tint-amount) | ||
); | ||
} @else { | ||
@include button-variant($value, $value); | ||
} | ||
} | ||
} | ||
|
||
@each $color, $value in $theme-colors { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicate of existing code (See l.148) |
||
.btn-outline-#{$color} { | ||
@include button-outline-variant($value); | ||
} | ||
} | ||
|
||
// scss-docs-end btn-variant-loops | ||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm wrong, it seems that you're creating several times
.btn-subtle
.The goal of the issue was to create a button that could change its color and bg-color contextually. I think it's not the code proposed here and it might not be the good way to do it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should I try making a new button ??
should the code be like?
@each $color, $value in $theme-colors {
.btn-tert {
@include button-variant($value, $value);
}
}
I am kinda beginner so please don't mind me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, even if I think that this feature is needed, this might be studied a bit more, I think that this kind of feature might be thought for whole Bootstrap at the same time at a naming and code level.
Let's continue the discussion in the issue, and when everyone agrees on the solution, let's create a PR.