Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Acknowledgement #2130

Merged
merged 12 commits into from
Jun 13, 2024
Merged

Async Acknowledgement #2130

merged 12 commits into from
Jun 13, 2024

Conversation

chipshort
Copy link
Collaborator

@chipshort chipshort commented Apr 25, 2024

closes #1721

This is a proposal for the async acknowledgement implementation. Happy to get opinions on this.

The packet can be identified by the combination of port, channel and sequence.
The port is unique to each contract and known to wasmd, so it's not needed to provide that explicitly.

To implement this in wasmd, we need to save the packet under some unique key (combination of the three data pieces above) when the contract returns no ack from ibc_packet_receive. Later when the contract calls WriteAcknowledgement, we try to load that saved packet and call the ibc-go WriteAcknowledgement function.
If this general approach sounds good then I can provide an implementation for wasmd.

@chipshort chipshort changed the base branch from ibc-callbacks to main May 10, 2024 15:16
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell. Just update and CHANGELOG missing.

Could you reach out to Serdar to get a review from the IBC team?

Copy link
Contributor

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chipshort chipshort merged commit 81c6ab8 into main Jun 13, 2024
31 checks passed
@chipshort chipshort deleted the chipshort/async-ack branch June 13, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give contracts finer control on IBC packet acknowledgement
3 participants