Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Acknowledgement #2130

Merged
merged 12 commits into from
Jun 13, 2024
Merged

Async Acknowledgement #2130

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4456df6
Add async ack prototype
chipshort Apr 23, 2024
792ca3a
Update schemas
chipshort Apr 25, 2024
caa6dfe
Update go-gen test
chipshort Apr 26, 2024
42a553e
Add async ack functionality to ibc-reflect
chipshort May 7, 2024
a753ae1
Remove IbcFullAcknowledgement from async ack
chipshort May 10, 2024
b8b842d
Fix ibc-reflect tests
chipshort May 10, 2024
35a7c5b
Update schemas
chipshort May 10, 2024
0172e81
Fix go-gen test
chipshort May 10, 2024
fcb34f0
Add 2.1 feature gate to WriteAcknowledgement
chipshort May 23, 2024
51b5cd9
Fix schemas
chipshort May 23, 2024
17f5cd3
Skip ibc-reflect cosmwasm-check in CI
chipshort May 23, 2024
e1be535
Add changelog entry
chipshort Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix go-gen test
  • Loading branch information
@chipshort
chipshort committed Jun 12, 2024
commit 0172e8151ee139f2cb1f58d66366613eeb6b9c00
8 changes: 2 additions & 6 deletions packages/go-gen/tests/cosmwasm_std__IbcMsg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ type SendPacketMsg struct {
}
type WriteAcknowledgementMsg struct {
// The acknowledgement to send back
Ack IBCFullAcknowledgement `json:"ack"`
Ack IBCAcknowledgement `json:"ack"`
// Existing channel where the packet was received
ChannelID string `json:"channel_id"`
// Sequence number of the packet that was received
Expand All @@ -35,12 +35,8 @@ type Coin struct {
Denom string `json:"denom"` // type, eg. "ATOM"
}

// The acknowledgement written by the module on the destination chain. It is different from the [`crate::IbcAcknowledgement`] as it can be unsuccessful.
type IBCFullAcknowledgement struct {
// The acknowledgement data returned by the module.
type IBCAcknowledgement struct {
Data []byte `json:"data"`
// Whether the acknowledgement was successful or not.
Success bool `json:"success"`
}

// IBCTimeout is the timeout for an IBC packet. At least one of block and timestamp is required.
Expand Down