Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Acknowledgement #2130

Merged
merged 12 commits into from
Jun 13, 2024
Merged

Async Acknowledgement #2130

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4456df6
Add async ack prototype
chipshort Apr 23, 2024
792ca3a
Update schemas
chipshort Apr 25, 2024
caa6dfe
Update go-gen test
chipshort Apr 26, 2024
42a553e
Add async ack functionality to ibc-reflect
chipshort May 7, 2024
a753ae1
Remove IbcFullAcknowledgement from async ack
chipshort May 10, 2024
b8b842d
Fix ibc-reflect tests
chipshort May 10, 2024
35a7c5b
Update schemas
chipshort May 10, 2024
0172e81
Fix go-gen test
chipshort May 10, 2024
fcb34f0
Add 2.1 feature gate to WriteAcknowledgement
chipshort May 23, 2024
51b5cd9
Fix schemas
chipshort May 23, 2024
17f5cd3
Skip ibc-reflect cosmwasm-check in CI
chipshort May 23, 2024
e1be535
Add changelog entry
chipshort Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix ibc-reflect tests
  • Loading branch information
@chipshort
chipshort committed Jun 12, 2024
commit b8b842d63902d74e98e42551751652319162f0c9
2 changes: 1 addition & 1 deletion contracts/ibc-reflect/src/contract.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ mod tests {
// acknowledgement is an error
let ack: AcknowledgementMsg<DispatchResponse> =
from_json(res.acknowledgement.unwrap()).unwrap();
assert_eq!(ack.unwrap_err(), "invalid packet: Error parsing into type ibc_reflect::msg::PacketMsg: unknown variant `reflect_code_id`, expected one of `dispatch`, `who_am_i`, `balances`, `panic`, `return_err`, `return_msgs`");
assert_eq!(ack.unwrap_err(), "invalid packet: Error parsing into type ibc_reflect::msg::PacketMsg: unknown variant `reflect_code_id`, expected one of `dispatch`, `who_am_i`, `balances`, `panic`, `return_err`, `return_msgs`, `no_ack`");
}

#[test]
Expand Down
2 changes: 1 addition & 1 deletion contracts/ibc-reflect/tests/integration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,5 +298,5 @@ fn handle_dispatch_packet() {
// acknowledgement is an error
let ack: AcknowledgementMsg<DispatchResponse> =
from_slice(&res.acknowledgement.unwrap(), DESERIALIZATION_LIMIT).unwrap();
assert_eq!(ack.unwrap_err(), "invalid packet: Error parsing into type ibc_reflect::msg::PacketMsg: unknown variant `reflect_code_id`, expected one of `dispatch`, `who_am_i`, `balances`, `panic`, `return_err`, `return_msgs`");
assert_eq!(ack.unwrap_err(), "invalid packet: Error parsing into type ibc_reflect::msg::PacketMsg: unknown variant `reflect_code_id`, expected one of `dispatch`, `who_am_i`, `balances`, `panic`, `return_err`, `return_msgs`, `no_ack`");
}