Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Acknowledgement #2130

Merged
merged 12 commits into from
Jun 13, 2024
Merged

Async Acknowledgement #2130

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4456df6
Add async ack prototype
chipshort Apr 23, 2024
792ca3a
Update schemas
chipshort Apr 25, 2024
caa6dfe
Update go-gen test
chipshort Apr 26, 2024
42a553e
Add async ack functionality to ibc-reflect
chipshort May 7, 2024
a753ae1
Remove IbcFullAcknowledgement from async ack
chipshort May 10, 2024
b8b842d
Fix ibc-reflect tests
chipshort May 10, 2024
35a7c5b
Update schemas
chipshort May 10, 2024
0172e81
Fix go-gen test
chipshort May 10, 2024
fcb34f0
Add 2.1 feature gate to WriteAcknowledgement
chipshort May 23, 2024
51b5cd9
Fix schemas
chipshort May 23, 2024
17f5cd3
Skip ibc-reflect cosmwasm-check in CI
chipshort May 23, 2024
e1be535
Add changelog entry
chipshort Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update schemas
  • Loading branch information
@chipshort
chipshort committed Jun 12, 2024
commit 35a7c5be5c3fdedd204e6ac9139f93db13a330ab
19 changes: 4 additions & 15 deletions contracts/ibc-reflect/schema/ibc-reflect.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"description": "The acknowledgement to send back",
"allOf": [
{
"$ref": "#/definitions/IbcFullAcknowledgement"
"$ref": "#/definitions/IbcAcknowledgement"
}
]
},
Expand Down Expand Up @@ -69,25 +69,14 @@
"description": "Binary is a wrapper around Vec<u8> to add base64 de/serialization with serde. It also adds some helper methods to help encode inline.\n\nThis is only needed as serde-json-{core,wasm} has a horrible encoding for Vec<u8>. See also <https://github.com/CosmWasm/cosmwasm/blob/main/docs/MESSAGE_TYPES.md>.",
"type": "string"
},
"IbcFullAcknowledgement": {
"description": "The acknowledgement written by the module on the destination chain. It is different from the [`crate::IbcAcknowledgement`] as it can be unsuccessful.",
"IbcAcknowledgement": {
"type": "object",
"required": [
"data",
"success"
"data"
],
"properties": {
"data": {
"description": "The acknowledgement data returned by the module.",
"allOf": [
{
"$ref": "#/definitions/Binary"
}
]
},
"success": {
"description": "Whether the acknowledgement was successful or not.",
"type": "boolean"
"$ref": "#/definitions/Binary"
}
},
"additionalProperties": false
Expand Down
19 changes: 4 additions & 15 deletions contracts/ibc-reflect/schema/ibc/packet_msg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,25 +403,14 @@
}
]
},
"IbcFullAcknowledgement": {
"description": "The acknowledgement written by the module on the destination chain. It is different from the [`crate::IbcAcknowledgement`] as it can be unsuccessful.",
"IbcAcknowledgement": {
"type": "object",
"required": [
"data",
"success"
"data"
],
"properties": {
"data": {
"description": "The acknowledgement data returned by the module.",
"allOf": [
{
"$ref": "#/definitions/Binary"
}
]
},
"success": {
"description": "Whether the acknowledgement was successful or not.",
"type": "boolean"
"$ref": "#/definitions/Binary"
}
},
"additionalProperties": false
Expand Down Expand Up @@ -536,7 +525,7 @@
"description": "The acknowledgement to send back",
"allOf": [
{
"$ref": "#/definitions/IbcFullAcknowledgement"
"$ref": "#/definitions/IbcAcknowledgement"
}
]
},
Expand Down
19 changes: 4 additions & 15 deletions contracts/ibc-reflect/schema/raw/execute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"description": "The acknowledgement to send back",
"allOf": [
{
"$ref": "#/definitions/IbcFullAcknowledgement"
"$ref": "#/definitions/IbcAcknowledgement"
}
]
},
Expand Down Expand Up @@ -48,25 +48,14 @@
"description": "Binary is a wrapper around Vec<u8> to add base64 de/serialization with serde. It also adds some helper methods to help encode inline.\n\nThis is only needed as serde-json-{core,wasm} has a horrible encoding for Vec<u8>. See also <https://github.com/CosmWasm/cosmwasm/blob/main/docs/MESSAGE_TYPES.md>.",
"type": "string"
},
"IbcFullAcknowledgement": {
"description": "The acknowledgement written by the module on the destination chain. It is different from the [`crate::IbcAcknowledgement`] as it can be unsuccessful.",
"IbcAcknowledgement": {
"type": "object",
"required": [
"data",
"success"
"data"
],
"properties": {
"data": {
"description": "The acknowledgement data returned by the module.",
"allOf": [
{
"$ref": "#/definitions/Binary"
}
]
},
"success": {
"description": "Whether the acknowledgement was successful or not.",
"type": "boolean"
"$ref": "#/definitions/Binary"
}
},
"additionalProperties": false
Expand Down
19 changes: 4 additions & 15 deletions contracts/reflect/schema/raw/execute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,25 +476,14 @@
}
]
},
"IbcFullAcknowledgement": {
"description": "The acknowledgement written by the module on the destination chain. It is different from the [`crate::IbcAcknowledgement`] as it can be unsuccessful.",
"IbcAcknowledgement": {
"type": "object",
"required": [
"data",
"success"
"data"
],
"properties": {
"data": {
"description": "The acknowledgement data returned by the module.",
"allOf": [
{
"$ref": "#/definitions/Binary"
}
]
},
"success": {
"description": "Whether the acknowledgement was successful or not.",
"type": "boolean"
"$ref": "#/definitions/Binary"
}
},
"additionalProperties": false
Expand Down Expand Up @@ -609,7 +598,7 @@
"description": "The acknowledgement to send back",
"allOf": [
{
"$ref": "#/definitions/IbcFullAcknowledgement"
"$ref": "#/definitions/IbcAcknowledgement"
}
]
},
Expand Down
19 changes: 4 additions & 15 deletions contracts/reflect/schema/reflect.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,25 +486,14 @@
}
]
},
"IbcFullAcknowledgement": {
"description": "The acknowledgement written by the module on the destination chain. It is different from the [`crate::IbcAcknowledgement`] as it can be unsuccessful.",
"IbcAcknowledgement": {
"type": "object",
"required": [
"data",
"success"
"data"
],
"properties": {
"data": {
"description": "The acknowledgement data returned by the module.",
"allOf": [
{
"$ref": "#/definitions/Binary"
}
]
},
"success": {
"description": "Whether the acknowledgement was successful or not.",
"type": "boolean"
"$ref": "#/definitions/Binary"
}
},
"additionalProperties": false
Expand Down Expand Up @@ -619,7 +608,7 @@
"description": "The acknowledgement to send back",
"allOf": [
{
"$ref": "#/definitions/IbcFullAcknowledgement"
"$ref": "#/definitions/IbcAcknowledgement"
}
]
},
Expand Down